rename completion constants and cleanup comment

pkg/analysis_server/lib/src/services/completion/local_computer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.computer.dart.local;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart' as protocol show Element,
     ElementKind;
@@ skipping 142 matching lines @@
     finished = true;
     return true;
   }
 
   CompletionSuggestion _addSuggestion(SimpleIdentifier id) {
     if (id != null) {
       String completion = id.name;
       if (completion != null && completion.length > 0 && completion != '_') {
         CompletionSuggestion suggestion = new CompletionSuggestion(
             CompletionSuggestionKind.IDENTIFIER,
-            COMPLETION_RELEVANCE_DEFAULT,
+            DART_RELEVANCE_DEFAULT,
             completion,
             completion.length,
             0,
             false,
             false);
         request.suggestions.add(suggestion);
         return suggestion;
       }
     }
     return null;
@@ skipping 30 matching lines @@
       this.excludeVoidReturn)
       : super(offset);
 
   @override
   void declaredClass(ClassDeclaration declaration) {
     bool isDeprecated = _isDeprecated(declaration);
     CompletionSuggestion suggestion = _addSuggestion(
         declaration.name,
         NO_RETURN_TYPE,
         isDeprecated,
-        COMPLETION_RELEVANCE_DEFAULT);
+        DART_RELEVANCE_DEFAULT);
     if (suggestion != null) {
       suggestion.element = _createElement(
           protocol.ElementKind.CLASS,
           declaration.name,
           returnType: NO_RETURN_TYPE,
           isAbstract: declaration.isAbstract,
           isDeprecated: isDeprecated);
     }
   }
 
   @override
   void declaredClassTypeAlias(ClassTypeAlias declaration) {
     bool isDeprecated = _isDeprecated(declaration);
     CompletionSuggestion suggestion = _addSuggestion(
         declaration.name,
         NO_RETURN_TYPE,
         isDeprecated,
-        COMPLETION_RELEVANCE_DEFAULT);
+        DART_RELEVANCE_DEFAULT);
     if (suggestion != null) {
       suggestion.element = _createElement(
           protocol.ElementKind.CLASS_TYPE_ALIAS,
           declaration.name,
           returnType: NO_RETURN_TYPE,
           isAbstract: true,
           isDeprecated: isDeprecated);
     }
   }
 
@@ skipping 20 matching lines @@
   }
 
   @override
   void declaredFunction(FunctionDeclaration declaration) {
     if (typesOnly) {
       return;
     }
     TypeName returnType = declaration.returnType;
     bool isDeprecated = _isDeprecated(declaration);
     protocol.ElementKind kind;
-    int defaultRelevance = COMPLETION_RELEVANCE_DEFAULT;
+    int defaultRelevance = DART_RELEVANCE_DEFAULT;
     if (declaration.isGetter) {
       kind = protocol.ElementKind.GETTER;
       defaultRelevance = DART_RELEVANCE_LOCAL_ACCESSOR;
     } else if (declaration.isSetter) {
       if (excludeVoidReturn) {
         return;
       }
       kind = protocol.ElementKind.SETTER;
       returnType = NO_RETURN_TYPE;
       defaultRelevance = DART_RELEVANCE_LOCAL_ACCESSOR;
@@ skipping 26 matching lines @@
   }
 
   @override
   void declaredFunctionTypeAlias(FunctionTypeAlias declaration) {
     bool isDeprecated = _isDeprecated(declaration);
     TypeName returnType = declaration.returnType;
     CompletionSuggestion suggestion = _addSuggestion(
         declaration.name,
         returnType,
         isDeprecated,
-        COMPLETION_RELEVANCE_DEFAULT);
+        DART_RELEVANCE_DEFAULT);
     if (suggestion != null) {
       // TODO (danrubel) determine parameters and return type
       suggestion.element = _createElement(
           protocol.ElementKind.FUNCTION_TYPE_ALIAS,
           declaration.name,
           returnType: returnType,
           isAbstract: true,
           isDeprecated: isDeprecated);
     }
   }
@@ skipping 17 matching lines @@
   }
 
   @override
   void declaredMethod(MethodDeclaration declaration) {
     if (typesOnly) {
       return;
     }
     protocol.ElementKind kind;
     String parameters;
     TypeName returnType = declaration.returnType;
-    int defaultRelevance = COMPLETION_RELEVANCE_DEFAULT;
+    int defaultRelevance = DART_RELEVANCE_DEFAULT;
     if (declaration.isGetter) {
       kind = protocol.ElementKind.GETTER;
       parameters = null;
       defaultRelevance = DART_RELEVANCE_LOCAL_ACCESSOR;
     } else if (declaration.isSetter) {
       if (excludeVoidReturn) {
         return;
       }
       kind = protocol.ElementKind.SETTER;
       returnType = NO_RETURN_TYPE;
@@ skipping 96 matching lines @@
         paramList.any((FormalParameter param) => param.kind == ParameterKind.NAMED);
   }
 
   CompletionSuggestion _addSuggestion(SimpleIdentifier id, TypeName returnType,
       bool isDeprecated, int defaultRelevance, {ClassDeclaration classDecl}) {
     if (id != null) {
       String completion = id.name;
       if (completion != null && completion.length > 0 && completion != '_') {
         CompletionSuggestion suggestion = new CompletionSuggestion(
             CompletionSuggestionKind.INVOCATION,
-            isDeprecated ? COMPLETION_RELEVANCE_LOW : defaultRelevance,
+            isDeprecated ? DART_RELEVANCE_LOW : defaultRelevance,
             completion,
             completion.length,
             0,
             isDeprecated,
             false,
             returnType: _nameForType(returnType));
         if (classDecl != null) {
           SimpleIdentifier identifier = classDecl.name;
           if (identifier != null) {
             String name = identifier.name;
@@ skipping 72 matching lines @@
     if (name == null || name.length <= 0) {
       return DYNAMIC;
     }
     TypeArgumentList typeArgs = type.typeArguments;
     if (typeArgs != null) {
       //TODO (danrubel) include type arguments
     }
     return name;
   }
 }