rename completion constants and cleanup comment

pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.suggestion.builder;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analysis_server/src/protocol_server.dart' as protocol;
 import 'package:analysis_server/src/protocol_server.dart' hide Element,
     ElementKind;
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/utilities_dart.dart';
 
 const String DYNAMIC = 'dynamic';
 
 /**
  * Return a suggestion based upon the given element
  * or `null` if a suggestion is not appropriate for the given element.
  */
 CompletionSuggestion createSuggestion(Element element,
     {CompletionSuggestionKind kind: CompletionSuggestionKind.INVOCATION,
-    int relevance: COMPLETION_RELEVANCE_DEFAULT}) {
+    int relevance: DART_RELEVANCE_DEFAULT}) {
 
   String nameForType(DartType type) {
     if (type == null) {
       return DYNAMIC;
     }
     String name = type.displayName;
     if (name == null || name.length <= 0) {
       return DYNAMIC;
     }
     //TODO (danrubel) include type arguments ??
@@ skipping 14 matching lines @@
   } else if (element is VariableElement) {
     returnType = nameForType(element.type);
   } else if (element is FunctionTypeAliasElement) {
     returnType = nameForType(element.returnType);
   }
 
   String completion = element.displayName;
   bool isDeprecated = element.isDeprecated;
   CompletionSuggestion suggestion = new CompletionSuggestion(
       kind,
-      isDeprecated ? COMPLETION_RELEVANCE_LOW : relevance,
+      isDeprecated ? DART_RELEVANCE_LOW : relevance,
       completion,
       completion.length,
       0,
       isDeprecated,
       false);
   suggestion.element = protocol.newElement_fromEngine(element);
   Element enclosingElement = element.enclosingElement;
   if (enclosingElement is ClassElement) {
     suggestion.declaringType = enclosingElement.displayName;
   }
@@ skipping 107 matching lines @@
   CompletionSuggestionKind get kind;
 
   /**
    * Return the request on which the builder is operating.
    */
   DartCompletionRequest get request;
 
   /**
    * Add a suggestion based upon the given element.
    */
-  void addSuggestion(Element element, {int relevance: COMPLETION_RELEVANCE_DEFAULT}) {
+  void addSuggestion(Element element, {int relevance: DART_RELEVANCE_DEFAULT}) {
     if (element.isPrivate) {
       LibraryElement elementLibrary = element.library;
       LibraryElement unitLibrary = request.unit.element.library;
       if (elementLibrary != unitLibrary) {
         return;
       }
     }
     if (element.isSynthetic) {
       if (element is PropertyAccessorElement || element is FieldElement) {
         return;
@@ skipping 373 matching lines @@
    * or `false` if [computeFull] should be called.
    */
   bool computeFast(AstNode node);
 
   /**
    * Return a future that computes the suggestions given a fully resolved AST.
    * The future returns `true` if suggestions were added, else `false`.
    */
   Future<bool> computeFull(AstNode node);
 }