rename completion constants and cleanup comment

pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.dart.cache;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analysis_server/src/protocol_server.dart' hide Element,
@@ skipping 160 matching lines @@
    */
   void _addDartCoreSuggestions() {
     Source coreUri = context.sourceFactory.forUri('dart:core');
     LibraryElement coreLib = context.getLibraryElement(coreUri);
     Namespace coreNamespace =
         new NamespaceBuilder().createPublicNamespaceForLibrary(coreLib);
     coreNamespace.definedNames.forEach((String name, Element elem) {
       if (elem is ClassElement) {
         importedClassMap[name] = elem;
       }
-      _addSuggestion(elem, COMPLETION_RELEVANCE_DEFAULT);
+      _addSuggestion(elem, DART_RELEVANCE_DEFAULT);
     });
   }
 
   /**
    * Add suggestions for explicitly imported and part elements in the given
    * library. Add libraries that should not have their elements suggested
    * even as low priority to [excludedLibs].
    */
   void _addImportedElemSuggestions(Source libSource, CompilationUnit libUnit,
       Set<LibraryElement> excludedLibs) {
     if (libUnit != null) {
       libUnit.directives.forEach((Directive directive) {
         if (directive is ImportDirective) {
           ImportElement importElem = directive.element;
           if (importElem != null && importElem.importedLibrary != null) {
             if (directive.prefix == null) {
               Namespace importNamespace =
                   new NamespaceBuilder().createImportNamespaceForDirective(importElem);
               // Include top level elements
               importNamespace.definedNames.forEach((String name, Element elem) {
                 if (elem is ClassElement) {
                   importedClassMap[name] = elem;
                 }
-                _addSuggestion(elem, COMPLETION_RELEVANCE_DEFAULT);
+                _addSuggestion(elem, DART_RELEVANCE_DEFAULT);
               });
             } else {
               // Exclude elements from prefixed imports
               // because they are provided by InvocationComputer
               _addLibraryPrefixSuggestion(importElem);
               excludedLibs.add(importElem.importedLibrary);
             }
           }
         } else if (directive is PartDirective) {
           CompilationUnitElement partElem = directive.element;
           if (partElem != null && partElem.source != source) {
             partElem.accept(new _NonLocalElementCacheVisitor(this));
           }
         }
       });
       if (libSource != source) {
         libUnit.element.accept(new _NonLocalElementCacheVisitor(this));
       }
     }
   }
 
   void _addLibraryPrefixSuggestion(ImportElement importElem) {
     CompletionSuggestion suggestion = null;
     String completion = importElem.prefix.displayName;
     if (completion != null && completion.length > 0) {
       suggestion = new CompletionSuggestion(
           CompletionSuggestionKind.INVOCATION,
-          COMPLETION_RELEVANCE_DEFAULT,
+          DART_RELEVANCE_DEFAULT,
           completion,
           completion.length,
           0,
           importElem.isDeprecated,
           false);
       LibraryElement lib = importElem.importedLibrary;
       if (lib != null) {
         suggestion.element = newElement_fromEngine(lib);
       }
       libraryPrefixSuggestions.add(suggestion);
       _importedCompletions.add(suggestion.completion);
     }
   }
 
   /**
    * Add suggestions for all top level elements in the context
    * excluding those elemnents for which suggestions have already been added.
    */
   void _addNonImportedElementSuggestions(List<SearchMatch> matches,
       Set<LibraryElement> excludedLibs) {
     matches.forEach((SearchMatch match) {
       if (match.kind == MatchKind.DECLARATION) {
         Element element = match.element;
         if (element.context == context &&
             element.isPublic &&
             !excludedLibs.contains(element.library) &&
             !_importedCompletions.contains(element.displayName)) {
-          _addSuggestion(element, COMPLETION_RELEVANCE_LOW);
+          _addSuggestion(element, DART_RELEVANCE_LOW);
         }
       }
     });
   }
 
   /**
    * Add a suggestion for the given element.
    */
   void _addSuggestion(Element element, int relevance) {
 
@@ skipping 55 matching lines @@
  * a source file contained in the same library but not the same as
  * the source in which the completions are being requested.
  */
 class _NonLocalElementCacheVisitor extends GeneralizingElementVisitor {
   final DartCompletionCache cache;
 
   _NonLocalElementCacheVisitor(this.cache);
 
   @override
   void visitClassElement(ClassElement element) {
-    cache._addSuggestion(element, COMPLETION_RELEVANCE_DEFAULT);
+    cache._addSuggestion(element, DART_RELEVANCE_DEFAULT);
   }
 
   @override
   void visitCompilationUnitElement(CompilationUnitElement element) {
     element.visitChildren(this);
   }
 
   @override
   void visitElement(Element element) {
     // ignored
   }
 
   @override
   void visitFunctionElement(FunctionElement element) {
-    cache._addSuggestion(element, COMPLETION_RELEVANCE_DEFAULT);
+    cache._addSuggestion(element, DART_RELEVANCE_DEFAULT);
   }
 
   @override
   void visitFunctionTypeAliasElement(FunctionTypeAliasElement element) {
-    cache._addSuggestion(element, COMPLETION_RELEVANCE_DEFAULT);
+    cache._addSuggestion(element, DART_RELEVANCE_DEFAULT);
   }
 
   @override
   void visitTopLevelVariableElement(TopLevelVariableElement element) {
-    cache._addSuggestion(element, COMPLETION_RELEVANCE_DEFAULT);
+    cache._addSuggestion(element, DART_RELEVANCE_DEFAULT);
   }
 }