Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 891473002: Move reflection support out of model. (Closed)

Created:
5 years, 10 months ago by herhut
Modified:
5 years, 10 months ago
Reviewers:
floitsch, zarah
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -27 lines) Patch
M pkg/compiler/lib/src/js_emitter/model.dart View 3 chunks +2 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart View 1 chunk +26 lines, -3 lines 2 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 6 chunks +5 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
herhut
5 years, 10 months ago (2015-01-29 14:47:51 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/891473002/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart File pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart (right): https://codereview.chromium.org/891473002/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart#newcode257 pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:257: final bool canBeReflected = backend.isAccessibleByReflection(member) || I prefer ...
5 years, 10 months ago (2015-01-29 15:01:22 UTC) #2
herhut
https://codereview.chromium.org/891473002/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart File pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart (right): https://codereview.chromium.org/891473002/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart#newcode257 pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:257: final bool canBeReflected = backend.isAccessibleByReflection(member) || On 2015/01/29 15:01:22, ...
5 years, 10 months ago (2015-01-29 15:04:21 UTC) #3
herhut
5 years, 10 months ago (2015-01-29 15:05:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43289 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698