Move reflection support out of model.

pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.js_emitter;
 
 /// This class should morph into something that makes it easy to build
 /// JavaScript representations of libraries, class-sides, and instance-sides.
 /// Initially, it is just a placeholder for code that is moved from
 /// [CodeEmitterTask].
@@ skipping 216 matching lines @@
               selector.argumentCount, selector.namedArguments);
           if (!selector.appliesUnnamed(member, compiler.world)) continue;
           if (untypedSelectors.add(selector)) {
             addParameterStub(member, selector, defineStub);
           }
         }
       }
     }
   }
 
+  String _tearOffNameForMember(FunctionElement member) {
+    if (member.isInstanceMember) {
+      return namer.getterName(member);
+    } else {
+      return namer.getStaticClosureName(member);
+    }
+  }
+
   void addMemberMethod(DartMethod method, ClassBuilder builder) {
     final FunctionElement member = method.element;
     String name = method.name;
     final FunctionSignature parameters = member.functionSignature;
     jsAst.Expression code = method.code;
     final bool needsStubs = method.needsStubs;
-    final bool canTearOff = method.needsTearOff;
-    final String tearOffName = method.tearOffName;
-    final bool canBeReflected = method.canBeReflected;
     final bool canBeApplied = method.canBeApplied;
+    bool canTearOff = method.needsTearOff;
+    String tearOffName = method.tearOffName;
     final bool isClosure = method is InstanceMethod && method.isClosure;
     final bool hasSuperAlias = method is InstanceMethod && method.hasSuperAlias;
 
+    final bool canBeReflected = backend.isAccessibleByReflection(member) ||

[floitsch, 2015/01/29 15:01:22]

I prefer if the comment is not on a sub-expression.
Maybe simply:

bool canBeReflected = backend.isAccessibleByReflection(member);

// During incremental compilation...
if (compiler.hasIncrementalSupport) canBeReflected = true;

[herhut, 2015/01/29 15:04:21]

Done.

+        // During incremental compilation, we have to assume that reflection
+        // *might* get enabled.
+        compiler.hasIncrementalSupport;
+
+    if (canBeReflected) {
+      // Patch the effects of reflection into the received information.
+      bool isNotApplyTarget = member.isConstructor ||
+                              member.isAccessor ||
+                              member.isOperator ||
+                              isClosure;
+      canTearOff = canTearOff || (canBeReflected && !isNotApplyTarget);
+      tearOffName = tearOffName != null ? tearOffName
+                                        : _tearOffNameForMember(member);
+    }
+
     final bool needStructuredInfo =
         canTearOff || canBeReflected || canBeApplied || hasSuperAlias;
 
     emitter.interceptorEmitter.recordMangledNameOfMemberMethod(member, name);
 
     if (!needStructuredInfo) {
       compiler.dumpInfoTask.registerElementAst(member,
           builder.addProperty(name, code));
       if (needsStubs) {
         addParameterStubs(
@@ skipping 169 matching lines @@
     jsAst.ArrayInitializer arrayInit =
       new jsAst.ArrayInitializer(expressions.toList());
     compiler.dumpInfoTask.registerElementAst(member,
         builder.addProperty(name, arrayInit));
   }
 
   void addMemberField(Field field, ClassBuilder builder) {
     // For now, do nothing.
   }
 }