Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder.dart

Issue 891473002: Move reflection support out of model. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/program_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder.dart
index 0caed929aa613602f69d9e1b5f20746fd0dcfcf3..b3ceabdbb83894533441cd9a2bf1ef7be2b22a7b 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder.dart
@@ -389,13 +389,6 @@ class ProgramBuilder {
return !method.functionSignature.optionalParameters.isEmpty;
}
- bool _methodCanBeReflected(FunctionElement method) {
- return backend.isAccessibleByReflection(method) ||
- // During incremental compilation, we have to assume that reflection
- // *might* get enabled.
- _compiler.hasIncrementalSupport;
- }
-
bool _methodCanBeApplied(FunctionElement method) {
return _compiler.enabledFunctionApply &&
_compiler.world.getMightBePassedToApply(method);
@@ -424,7 +417,6 @@ class ProgramBuilder {
bool isNotApplyTarget = !element.isFunction || element.isAccessor;
final bool needsStubs = _methodNeedsStubs(element);
- final bool canBeReflected = _methodCanBeReflected(element);
final bool canBeApplied = _methodCanBeApplied(element);
final bool hasSuperAlias = backend.isAliasedSuperMember(element);
@@ -436,8 +428,7 @@ class ProgramBuilder {
isClosure = true;
} else {
// Careful with operators.
- canTearOff = universe.hasInvokedGetter(element, _compiler.world) ||
- (canBeReflected && !element.isOperator);
+ canTearOff = universe.hasInvokedGetter(element, _compiler.world);
assert(canTearOff ||
!universe.methodsNeedingSuperGetter.contains(element));
tearOffName = namer.getterName(element);
@@ -453,7 +444,7 @@ class ProgramBuilder {
return new InstanceMethod(element, name, code, needsTearOff: canTearOff,
tearOffName: tearOffName, isClosure: isClosure,
hasSuperAlias: hasSuperAlias, canBeApplied: canBeApplied,
- canBeReflected: canBeReflected, needsStubs: needsStubs);
+ needsStubs: needsStubs);
}
/// Builds a stub method.
@@ -561,13 +552,12 @@ class ProgramBuilder {
String holder = namer.globalObjectFor(element);
js.Expression code = backend.generatedCode[element];
- final bool isNotApplyTarget = !element.isConstructor && !element.isAccessor;
final bool needsStubs = _methodNeedsStubs(element);
final bool canBeApplied = _methodCanBeApplied(element);
- final bool canBeReflected = _methodCanBeReflected(element);
- final bool needsTearOff = isNotApplyTarget && (canBeReflected ||
- universe.staticFunctionsNeedingGetter.contains(element));
+ final bool isApplyTarget = !element.isConstructor && !element.isAccessor;
+ final bool needsTearOff = isApplyTarget &&
+ universe.staticFunctionsNeedingGetter.contains(element);
final String tearOffName =
needsTearOff ? namer.getStaticClosureName(element) : null;
@@ -577,7 +567,6 @@ class ProgramBuilder {
needsTearOff: needsTearOff,
tearOffName: tearOffName,
canBeApplied: canBeApplied,
- canBeReflected: canBeReflected,
needsStubs: needsStubs);
}

Powered by Google App Engine
This is Rietveld 408576698