Move reflection support out of model.

pkg/compiler/lib/src/js_emitter/program_builder.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.js_emitter.program_builder;
 
 import 'js_emitter.dart' show computeMixinClass;
 import 'model.dart';
 
 import '../common.dart';
@@ skipping 371 matching lines @@
                          isNative: element.isNative);
     }
     _classes[element] = result;
     return result;
   }
 
   bool _methodNeedsStubs(FunctionElement method) {
     return !method.functionSignature.optionalParameters.isEmpty;
   }
 
-  bool _methodCanBeReflected(FunctionElement method) {
-    return backend.isAccessibleByReflection(method) ||
-        // During incremental compilation, we have to assume that reflection
-        // *might* get enabled.
-        _compiler.hasIncrementalSupport;
-  }
-
   bool _methodCanBeApplied(FunctionElement method) {
     return _compiler.enabledFunctionApply &&
         _compiler.world.getMightBePassedToApply(method);
   }
 
   // TODO(herhut): Refactor incremental compilation and remove method.
   Method buildMethodHackForIncrementalCompilation(FunctionElement element) {
     assert(_compiler.hasIncrementalSupport);
     if (element.isInstanceMember) {
       return _buildMethod(element);
     } else {
       return _buildStaticMethod(element);
     }
   }
 
   DartMethod _buildMethod(FunctionElement element) {
     String name = namer.getNameOfInstanceMember(element);
     js.Expression code = backend.generatedCode[element];
 
     // TODO(kasperl): Figure out under which conditions code is null.
     if (code == null) return null;
 
     bool canTearOff = false;
     String tearOffName;
     bool isClosure = false;
     bool isNotApplyTarget = !element.isFunction || element.isAccessor;
 
     final bool needsStubs = _methodNeedsStubs(element);
-    final bool canBeReflected = _methodCanBeReflected(element);
     final bool canBeApplied = _methodCanBeApplied(element);
     final bool hasSuperAlias = backend.isAliasedSuperMember(element);
 
     if (isNotApplyTarget) {
       canTearOff = false;
     } else {
       if (element.enclosingClass.isClosure) {
         canTearOff = false;
         isClosure = true;
       } else {
         // Careful with operators.
-        canTearOff = universe.hasInvokedGetter(element, _compiler.world) ||
-            (canBeReflected && !element.isOperator);
+        canTearOff = universe.hasInvokedGetter(element, _compiler.world);
         assert(canTearOff ||
                !universe.methodsNeedingSuperGetter.contains(element));
         tearOffName = namer.getterName(element);
       }
     }
 
     if (canTearOff) {
       assert(invariant(element, !element.isGenerativeConstructor));
       assert(invariant(element, !element.isGenerativeConstructorBody));
       assert(invariant(element, !element.isConstructor));
     }
 
     return new InstanceMethod(element, name, code, needsTearOff: canTearOff,
         tearOffName: tearOffName, isClosure: isClosure,
         hasSuperAlias: hasSuperAlias, canBeApplied: canBeApplied,
-        canBeReflected: canBeReflected, needsStubs: needsStubs);
+        needsStubs: needsStubs);
   }
 
   /// Builds a stub method.
   ///
   /// Stub methods may have an element that can be used for code-size
   /// attribution.
   Method _buildStubMethod(String name, js.Expression code,
                           {Element element}) {
     return new StubMethod(name, code, element: element);
   }
@@ skipping 87 matching lines @@
       js.Expression code = stubGenerator.generateOneShotInterceptor(name);
       return new StaticStubMethod(name, holder, code);
     });
   }
 
   StaticMethod _buildStaticMethod(FunctionElement element) {
     String name = namer.getNameOfMember(element);
     String holder = namer.globalObjectFor(element);
     js.Expression code = backend.generatedCode[element];
 
-    final bool isNotApplyTarget = !element.isConstructor && !element.isAccessor;
     final bool needsStubs = _methodNeedsStubs(element);
     final bool canBeApplied = _methodCanBeApplied(element);
-    final bool canBeReflected = _methodCanBeReflected(element);
 
-    final bool needsTearOff = isNotApplyTarget && (canBeReflected ||
-         universe.staticFunctionsNeedingGetter.contains(element));
+    final bool isApplyTarget = !element.isConstructor && !element.isAccessor;
+    final bool needsTearOff = isApplyTarget &&
+         universe.staticFunctionsNeedingGetter.contains(element);
 
     final String tearOffName =
         needsTearOff ? namer.getStaticClosureName(element) : null;
 
     return new StaticMethod(element,
                             name, _registry.registerHolder(holder), code,
                             needsTearOff: needsTearOff,
                             tearOffName: tearOffName,
                             canBeApplied: canBeApplied,
-                            canBeReflected: canBeReflected,
                             needsStubs: needsStubs);
   }
 
   void _registerConstants(OutputUnit outputUnit,
                           Iterable<ConstantValue> constantValues) {
     // `constantValues` is null if an outputUnit doesn't contain any constants.
     if (constantValues == null) return;
     for (ConstantValue constantValue in constantValues) {
       _registry.registerConstant(outputUnit, constantValue);
       assert(!_constants.containsKey(constantValue));
       String name = namer.constantName(constantValue);
       String constantObject = namer.globalObjectForConstant(constantValue);
       Holder holder = _registry.registerHolder(constantObject);
       Constant constant = new Constant(name, holder, constantValue);
       _constants[constantValue] = constant;
     }
   }
 }