Issue 887943004: Check PackageMapUriResolver constructor arguments.

Issue 887943004: Check PackageMapUriResolver constructor arguments. (Closed)

Created:
5 years, 10 months ago by scheglov

Modified:
5 years, 10 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Check PackageMapUriResolver constructor arguments. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43405

Patch Set 2 : Fixes for the server and tests #

Total comments: 2

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -56 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/context_manager.dart	View	1	1 chunk	+9 lines, -7 lines	0 comments	Download
M	pkg/analysis_server/test/context_manager_test.dart	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/analyzer/lib/source/package_map_resolver.dart	View		2 chunks	+5 lines, -1 line	0 comments	Download
A	pkg/analyzer/lib/src/util/asserts.dart	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/source/package_map_resolver_test.dart	View		2 chunks	+16 lines, -36 lines	0 comments	Download
M	pkg/analyzer/test/src/test_all.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
A	pkg/analyzer/test/src/util/asserts_test.dart	View		1 chunk	+36 lines, -0 lines	2 comments	Download
A +	pkg/analyzer/test/src/util/test_all.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/887943004/diff/20001/pkg/analyzer/test/src/util/asserts_test.dart File pkg/analyzer/test/src/util/asserts_test.dart (right): https://codereview.chromium.org/887943004/diff/20001/pkg/analyzer/test/src/util/asserts_test.dart#newcode29 pkg/analyzer/test/src/util/asserts_test.dart:29: throwsA(new isInstanceOf<ArgumentError>())); I can't check, but is there ...

5 years, 10 months ago (2015-02-03 14:54:42 UTC) #2

scheglov

https://codereview.chromium.org/887943004/diff/20001/pkg/analyzer/test/src/util/asserts_test.dart File pkg/analyzer/test/src/util/asserts_test.dart (right): https://codereview.chromium.org/887943004/diff/20001/pkg/analyzer/test/src/util/asserts_test.dart#newcode29 pkg/analyzer/test/src/util/asserts_test.dart:29: throwsA(new isInstanceOf<ArgumentError>())); On 2015/02/03 14:54:42, Brian Wilkerson wrote: > ...

5 years, 10 months ago (2015-02-03 16:06:12 UTC) #4

scheglov

5 years, 10 months ago (2015-02-03 16:06:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 43405 (presubmit successful).

Expand Messages | Collapse Messages