pkg/analyzer/lib/source/package_map_resolver.dart - Issue 887943004: Check PackageMapUriResolver constructor arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/source/package_map_resolver.dart

Issue 887943004: Check PackageMapUriResolver constructor arguments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fixes for the server and tests Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/context_manager_test.dart ('k') | pkg/analyzer/lib/src/util/asserts.dart » ('j') | pkg/analyzer/test/src/util/asserts_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer/lib/source/package_map_resolver.dart

diff --git a/pkg/analyzer/lib/source/package_map_resolver.dart b/pkg/analyzer/lib/source/package_map_resolver.dart

index de2c67374dac1e57541c76123ce459fc06f00970..2f70b864e78066cf3760dfd67740b3f3b34ff759 100644

--- a/pkg/analyzer/lib/source/package_map_resolver.dart

+++ b/pkg/analyzer/lib/source/package_map_resolver.dart

@@ -6,6 +6,7 @@ library source.package_map_resolver;

import 'package:analyzer/file_system/file_system.dart';

import 'package:analyzer/src/generated/source.dart';

+import 'package:analyzer/src/util/asserts.dart' as asserts;

/**

@@ -35,7 +36,10 @@ class PackageMapUriResolver extends UriResolver {

* [packageMap] is a table mapping package names to the paths of the

* directories containing the package

- PackageMapUriResolver(this.resourceProvider, this.packageMap);

+ PackageMapUriResolver(this.resourceProvider, this.packageMap) {

+ asserts.notNull(resourceProvider);

+ asserts.notNull(packageMap);

+ }

@override

Source resolveAbsolute(Uri uri) {