Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: pkg/analyzer/test/source/package_map_resolver_test.dart

Issue 887943004: Check PackageMapUriResolver constructor arguments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixes for the server and tests Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/source/package_map_resolver_test.dart
diff --git a/pkg/analyzer/test/source/package_map_resolver_test.dart b/pkg/analyzer/test/source/package_map_resolver_test.dart
index b7a644a7ce8ee93fb30fc4d597b9b0ed311ba813..a12e361680fd6e6e7c254957bd3e896ef292f9d1 100644
--- a/pkg/analyzer/test/source/package_map_resolver_test.dart
+++ b/pkg/analyzer/test/source/package_map_resolver_test.dart
@@ -10,48 +10,16 @@ import 'package:analyzer/source/package_map_resolver.dart';
import 'package:analyzer/src/generated/source.dart';
import 'package:unittest/unittest.dart';
+import '../reflective_tests.dart';
+
main() {
groupSep = ' | ';
- group('PackageMapUriResolverTest', () {
- test('isPackageUri', () {
- new _PackageMapUriResolverTest().test_isPackageUri();
- });
- test('isPackageUri_null_scheme', () {
- new _PackageMapUriResolverTest().test_isPackageUri_null_scheme();
- });
- test('isPackageUri_other_scheme', () {
- new _PackageMapUriResolverTest().test_isPackageUri_other_scheme();
- });
- test('resolve_multiple_folders', () {
- new _PackageMapUriResolverTest().test_resolve_multiple_folders();
- });
- test('resolve_nonPackage', () {
- new _PackageMapUriResolverTest().test_resolve_nonPackage();
- });
- test('resolve_OK', () {
- new _PackageMapUriResolverTest().test_resolve_OK();
- });
- test('resolve_package_invalid_leadingSlash', () {
- var inst = new _PackageMapUriResolverTest();
- inst.test_resolve_package_invalid_leadingSlash();
- });
- test('resolve_package_invalid_noSlash', () {
- new _PackageMapUriResolverTest().test_resolve_package_invalid_noSlash();
- });
- test('resolve_package_invalid_onlySlash', () {
- new _PackageMapUriResolverTest().test_resolve_package_invalid_onlySlash();
- });
- test('resolve_package_notInMap', () {
- new _PackageMapUriResolverTest().test_resolve_package_notInMap();
- });
- test('restoreAbsolute_OK', () {
- new _PackageMapUriResolverTest().test_restoreAbsolute();
- });
- });
+ runReflectiveTests(_PackageMapUriResolverTest);
}
+@reflectiveTest
class _PackageMapUriResolverTest {
static const Map EMPTY_MAP = const <String, List<Folder>>{};
MemoryResourceProvider provider = new MemoryResourceProvider();
@@ -74,6 +42,18 @@ class _PackageMapUriResolverTest {
expect(PackageMapUriResolver.isPackageUri(uri), isFalse);
}
+ void test_new_null_packageMap() {
+ expect(() {
+ new PackageMapUriResolver(provider, null);
+ }, throws);
+ }
+
+ void test_new_null_resourceProvider() {
+ expect(() {
+ new PackageMapUriResolver(null, <String, List<Folder>>{});
+ }, throws);
+ }
+
void test_resolve_multiple_folders() {
const pkgFileA = '/part1/lib/libA.dart';
const pkgFileB = '/part2/lib/libB.dart';

Powered by Google App Engine
This is Rietveld 408576698