pkg/analysis_server/lib/src/analysis_server.dart - Issue 887943004: Check PackageMapUriResolver constructor arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 887943004: Check PackageMapUriResolver constructor arguments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fixes for the server and tests Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/analysis_server.dart

diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart

index 4552eb8e4852cb36746ed26ba374a47ed874e3a4..34531c68402f067b09086303653ce0da85ddc780 100644

--- a/pkg/analysis_server/lib/src/analysis_server.dart

+++ b/pkg/analysis_server/lib/src/analysis_server.dart

@@ -1173,8 +1173,10 @@ class ServerContextManager extends ContextManager {

SourceFactory _createSourceFactory(UriResolver packageUriResolver) {

List<UriResolver> resolvers = <UriResolver>[

new DartUriResolver(analysisServer.defaultSdk),

- new ResourceUriResolver(resourceProvider),

- packageUriResolver];

+ new ResourceUriResolver(resourceProvider)];

+ if (packageUriResolver != null) {

+ resolvers.add(packageUriResolver);

+ }

return new SourceFactory(resolvers);

}

« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/context_manager.dart » ('j') | pkg/analyzer/test/src/util/asserts_test.dart » ('J')