Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 845553005: Change code completion relevance from CompletionRelevance.LOW/DEFAULT/HIGH to int (Closed)

Created:
5 years, 11 months ago by danrubel
Modified:
5 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Change code completion relevance from CompletionRelevance.LOW/DEFAULT/HIGH to int This allows the sever to return a more graduated relevance and facilitates moving client side prioritization over to the server. BUG= R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=42735

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -300 lines) Patch
D editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionRelevance.java View 1 chunk +0 lines, -32 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestion.java View 5 chunks +7 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java View 5 chunks +4 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/completion/DartSuggestionReceiverTest.java View 5 chunks +5 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java View 4 chunks +12 lines, -31 lines 1 comment Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalComparator.java View 2 chunks +5 lines, -1 line 0 comments Download
M pkg/analysis_server/doc/api.html View 3 chunks +4 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 4 chunks +7 lines, -55 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/arglist_computer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart View 8 chunks +10 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/imported_computer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/keyword_computer.dart View 5 chunks +11 lines, -11 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +2 lines, -17 lines 0 comments Download
M pkg/analysis_server/test/services/completion/combinator_computer_test.dart View 3 chunks +13 lines, -12 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_computer_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 47 chunks +69 lines, -69 lines 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_computer_test.dart View 12 chunks +12 lines, -11 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 2 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
https://codereview.chromium.org/845553005/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java File editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java (right): https://codereview.chromium.org/845553005/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java#newcode552 editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java:552: if (relevance != 1000) { This code will be ...
5 years, 11 months ago (2015-01-08 22:38:03 UTC) #2
Brian Wilkerson
LGTM
5 years, 11 months ago (2015-01-08 23:45:52 UTC) #3
danrubel
5 years, 11 months ago (2015-01-09 15:31:14 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 42735 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698