Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Unified Diff: pkg/analysis_server/test/services/completion/keyword_computer_test.dart

Issue 845553005: Change code completion relevance from CompletionRelevance.LOW/DEFAULT/HIGH to int (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/keyword_computer_test.dart
diff --git a/pkg/analysis_server/test/services/completion/keyword_computer_test.dart b/pkg/analysis_server/test/services/completion/keyword_computer_test.dart
index f6d7fed3d5d74a71f4439215056d0b36849fbc23..ef0e4eeda0d1636b1a03ba175fa78bb9e69e3e79 100644
--- a/pkg/analysis_server/test/services/completion/keyword_computer_test.dart
+++ b/pkg/analysis_server/test/services/completion/keyword_computer_test.dart
@@ -5,6 +5,7 @@
library test.services.completion.dart.keyword;
import 'package:analysis_server/src/protocol.dart';
+import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
import 'package:analysis_server/src/services/completion/keyword_computer.dart';
import 'package:analyzer/src/generated/scanner.dart';
import 'package:unittest/unittest.dart';
@@ -21,7 +22,7 @@ main() {
class KeywordComputerTest extends AbstractCompletionTest {
void assertSuggestKeywords(Iterable<Keyword> expectedKeywords,
- [CompletionRelevance relevance = CompletionRelevance.DEFAULT]) {
+ [int relevance = COMPLETION_RELEVANCE_DEFAULT]) {
Set<Keyword> actualKeywords = new Set<Keyword>();
request.suggestions.forEach((CompletionSuggestion s) {
if (s.kind == CompletionSuggestionKind.KEYWORD) {
@@ -75,7 +76,7 @@ class KeywordComputerTest extends AbstractCompletionTest {
Keyword.FINAL,
Keyword.TYPEDEF,
Keyword.VAR],
- CompletionRelevance.HIGH);
+ COMPLETION_RELEVANCE_HIGH);
}
test_before_import() {
@@ -83,7 +84,7 @@ class KeywordComputerTest extends AbstractCompletionTest {
expect(computeFast(), isTrue);
assertSuggestKeywords(
[Keyword.EXPORT, Keyword.IMPORT, Keyword.LIBRARY, Keyword.PART],
- CompletionRelevance.HIGH);
+ COMPLETION_RELEVANCE_HIGH);
}
test_class() {
@@ -91,7 +92,7 @@ class KeywordComputerTest extends AbstractCompletionTest {
expect(computeFast(), isTrue);
assertSuggestKeywords(
[Keyword.EXTENDS, Keyword.IMPLEMENTS],
- CompletionRelevance.HIGH);
+ COMPLETION_RELEVANCE_HIGH);
}
test_class_extends() {
@@ -99,7 +100,7 @@ class KeywordComputerTest extends AbstractCompletionTest {
expect(computeFast(), isTrue);
assertSuggestKeywords(
[Keyword.IMPLEMENTS, Keyword.WITH],
- CompletionRelevance.HIGH);
+ COMPLETION_RELEVANCE_HIGH);
}
test_class_extends_name() {
@@ -111,7 +112,7 @@ class KeywordComputerTest extends AbstractCompletionTest {
test_class_implements() {
addTestSource('class A ^ implements foo');
expect(computeFast(), isTrue);
- assertSuggestKeywords([Keyword.EXTENDS], CompletionRelevance.HIGH);
+ assertSuggestKeywords([Keyword.EXTENDS], COMPLETION_RELEVANCE_HIGH);
}
test_class_implements_name() {
@@ -147,7 +148,7 @@ class KeywordComputerTest extends AbstractCompletionTest {
Keyword.PART,
Keyword.TYPEDEF,
Keyword.VAR],
- CompletionRelevance.HIGH);
+ COMPLETION_RELEVANCE_HIGH);
}
test_function_body() {
@@ -207,7 +208,7 @@ class KeywordComputerTest extends AbstractCompletionTest {
Keyword.PART,
Keyword.TYPEDEF,
Keyword.VAR],
- CompletionRelevance.HIGH);
+ COMPLETION_RELEVANCE_HIGH);
}
test_library_name() {
@@ -262,7 +263,7 @@ class KeywordComputerTest extends AbstractCompletionTest {
Keyword.PART,
Keyword.TYPEDEF,
Keyword.VAR],
- CompletionRelevance.HIGH);
+ COMPLETION_RELEVANCE_HIGH);
}
test_partial_class() {
@@ -280,7 +281,7 @@ class KeywordComputerTest extends AbstractCompletionTest {
Keyword.PART,
Keyword.TYPEDEF,
Keyword.VAR],
- CompletionRelevance.HIGH);
+ COMPLETION_RELEVANCE_HIGH);
}
test_partial_class2() {
@@ -297,7 +298,7 @@ class KeywordComputerTest extends AbstractCompletionTest {
Keyword.PART,
Keyword.TYPEDEF,
Keyword.VAR],
- CompletionRelevance.HIGH);
+ COMPLETION_RELEVANCE_HIGH);
}
void _appendKeywords(StringBuffer msg, Iterable<Keyword> keywords) {

Powered by Google App Engine
This is Rietveld 408576698