Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java

Issue 845553005: Change code completion relevance from CompletionRelevance.LOW/DEFAULT/HIGH to int (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java
diff --git a/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java b/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java
index b32c565063c4940b4673c8e8b22788deb23703c7..acd9699e8057f0ad29844be48f82e7d22ea86768 100644
--- a/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java
+++ b/editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java
@@ -42,7 +42,6 @@ import com.google.dart.server.generated.types.AnalysisOptions;
import com.google.dart.server.generated.types.AnalysisService;
import com.google.dart.server.generated.types.AnalysisStatus;
import com.google.dart.server.generated.types.ChangeContentOverlay;
-import com.google.dart.server.generated.types.CompletionRelevance;
import com.google.dart.server.generated.types.CompletionSuggestion;
import com.google.dart.server.generated.types.CompletionSuggestionKind;
import com.google.dart.server.generated.types.Element;
@@ -1262,7 +1261,7 @@ public class RemoteAnalysisServerImplTest extends AbstractRemoteServerTest {
" 'results' : [",
" {",
" 'kind': 'INVOCATION',",
- " 'relevance': 'LOW',",
+ " 'relevance': 2000,",
" 'completion': 'completion0',",
" 'selectionOffset': 4,",
" 'selectionLength': 5,",
@@ -1287,7 +1286,7 @@ public class RemoteAnalysisServerImplTest extends AbstractRemoteServerTest {
" },",
" {",
" 'kind': 'IDENTIFIER',",
- " 'relevance': 'DEFAULT',",
+ " 'relevance': 1000,",
" 'completion': 'completion1',",
" 'selectionOffset': 10,",
" 'selectionLength': 11,",
@@ -1313,7 +1312,7 @@ public class RemoteAnalysisServerImplTest extends AbstractRemoteServerTest {
{
CompletionSuggestion suggestion = suggestions.get(0);
assertEquals(CompletionSuggestionKind.INVOCATION, suggestion.getKind());
- assertEquals(CompletionRelevance.LOW, suggestion.getRelevance());
+ assertEquals(2000, suggestion.getRelevance());
assertEquals(suggestion.getCompletion(), "completion0");
assertEquals(4, suggestion.getSelectionOffset());
assertEquals(5, suggestion.getSelectionLength());
@@ -1346,7 +1345,7 @@ public class RemoteAnalysisServerImplTest extends AbstractRemoteServerTest {
{
CompletionSuggestion suggestion = suggestions.get(1);
assertEquals(CompletionSuggestionKind.IDENTIFIER, suggestion.getKind());
- assertEquals(CompletionRelevance.DEFAULT, suggestion.getRelevance());
+ assertEquals(1000, suggestion.getRelevance());
assertEquals(suggestion.getCompletion(), "completion1");
assertEquals(10, suggestion.getSelectionOffset());
assertEquals(11, suggestion.getSelectionLength());

Powered by Google App Engine
This is Rietveld 408576698