editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalComparator.java - Issue 845553005: Change code completion relevance from CompletionRelevance.LOW/DEFAULT/HIGH to int

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalComparator.java

Issue 845553005: Change code completion relevance from CompletionRelevance.LOW/DEFAULT/HIGH to int (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java ('K') | « editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java ('k') | pkg/analysis_server/doc/api.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalComparator.java

diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalComparator.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalComparator.java

index c137ea09469f6838d141f57de098bf935ed70dfe..24de6b56182d5fe26792787e46802026f96bb11c 100644

--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalComparator.java

+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/CompletionProposalComparator.java

@@ -14,6 +14,7 @@

package com.google.dart.tools.ui.text.dart;

import com.google.dart.tools.ui.internal.text.completion.AbstractDartCompletionProposal;

+import com.google.dart.tools.ui.internal.text.dart.DartServerProposal;

import org.eclipse.jface.text.contentassist.ICompletionProposal;

import org.eclipse.jface.text.templates.TemplateProposal;

@@ -78,7 +79,10 @@ public final class CompletionProposalComparator implements Comparator<Object> {

private int getRelevance(ICompletionProposal obj) {

if (obj instanceof IDartCompletionProposal) {

IDartCompletionProposal jcp = (IDartCompletionProposal) obj;

- return jcp.getRelevance();

+ int relevance = jcp.getRelevance();

+ // Dart Analysis Server relevance is higher number is higher relevance

+ // where as Eclipse relevance is lower number is higher relevance

+ return jcp instanceof DartServerProposal ? -relevance : relevance;

} else if (obj instanceof TemplateProposal) {

TemplateProposal tp = (TemplateProposal) obj;

return tp.getRelevance();