Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 828413004: Don’t exit prematurely if compilation failed. (Closed)

Created:
5 years, 11 months ago by ahe
Modified:
5 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/no_cop_out
Visibility:
Public.

Description

Don’t exit prematurely if compilation failed. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42905

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Merged with r42904. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -14 lines) Patch
M dart/pkg/compiler/lib/src/compiler.dart View 1 8 chunks +24 lines, -8 lines 0 comments Download
M dart/pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M dart/pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M dart/pkg/compiler/lib/src/resolution/members.dart View 1 3 chunks +5 lines, -2 lines 0 comments Download
M dart/pkg/compiler/lib/src/ssa/builder.dart View 1 6 chunks +28 lines, -4 lines 0 comments Download
M dart/pkg/compiler/lib/src/ssa/optimize.dart View 1 chunk +1 line, -0 lines 0 comments Download
A dart/tests/compiler/dart2js_extra/LayoutTests_fast_mediastream_getusermedia_t01_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
I believe this will help avoid crashing incremental compilation.
5 years, 11 months ago (2015-01-14 17:25:43 UTC) #3
Johnni Winther
LGTM but add an opt-in option for generating output despite compilation errors. https://codereview.chromium.org/828413004/diff/20001/dart/pkg/compiler/lib/src/compiler.dart File dart/pkg/compiler/lib/src/compiler.dart ...
5 years, 11 months ago (2015-01-15 11:34:47 UTC) #4
ahe
On 2015/01/15 11:34:47, Johnni Winther wrote: > LGTM but add an opt-in option for generating ...
5 years, 11 months ago (2015-01-15 12:09:31 UTC) #5
ahe
5 years, 11 months ago (2015-01-15 12:12:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as 42905 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698