dart/pkg/compiler/lib/src/js_backend/backend.dart - Issue 828413004: Don’t exit prematurely if compilation failed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/pkg/compiler/lib/src/js_backend/backend.dart

Issue 828413004: Don’t exit prematurely if compilation failed. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Merged with r42904. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/pkg/compiler/lib/src/js_backend/backend.dart

diff --git a/dart/pkg/compiler/lib/src/js_backend/backend.dart b/dart/pkg/compiler/lib/src/js_backend/backend.dart

index d57e9a2a3e6372a29f937e3a4f79c5f0e5aedfae..48544c30a2b70c18aa28b8c755fff358c8d5572e 100644

--- a/dart/pkg/compiler/lib/src/js_backend/backend.dart

+++ b/dart/pkg/compiler/lib/src/js_backend/backend.dart

@@ -1200,6 +1200,11 @@ class JavaScriptBackend extends Backend {

void codegen(CodegenWorkItem work) {

Element element = work.element;

+ if (compiler.elementHasCompileTimeError(element)) {

+ generatedCode[element] = jsAst.js(

+ "function () { throw new Error('Compile time error in $element') }");

+ return;

+ }

var kind = element.kind;

if (kind == ElementKind.TYPEDEF) return;

if (element.isConstructor && element.enclosingClass == jsNullClass) {