dart/pkg/compiler/lib/src/ssa/optimize.dart - Issue 828413004: Don’t exit prematurely if compilation failed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/pkg/compiler/lib/src/ssa/optimize.dart

Issue 828413004: Don’t exit prematurely if compilation failed. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Merged with r42904. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/pkg/compiler/lib/src/ssa/optimize.dart

diff --git a/dart/pkg/compiler/lib/src/ssa/optimize.dart b/dart/pkg/compiler/lib/src/ssa/optimize.dart

index 38bf3cf0683a172f90af249ccff31467ca8e90e1..9aa51f0d21e1b0f8ab51293b1fbabb625c6fedc3 100644

--- a/dart/pkg/compiler/lib/src/ssa/optimize.dart

+++ b/dart/pkg/compiler/lib/src/ssa/optimize.dart

@@ -1843,6 +1843,7 @@ class SsaLoadElimination extends HBaseVisitor implements OptimizationPhase {

memorySet.registerAllocation(instruction);

int argumentIndex = 0;

instruction.element.forEachInstanceField((_, Element member) {

+ if (compiler.elementHasCompileTimeError(member)) return;

memorySet.registerFieldValue(

member, instruction, instruction.inputs[argumentIndex++]);

}, includeSuperAndInjectedMembers: true);