Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2507)

Unified Diff: dart/pkg/compiler/lib/src/resolution/members.dart

Issue 828413004: Don’t exit prematurely if compilation failed. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Merged with r42904. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/pkg/compiler/lib/src/resolution/members.dart
diff --git a/dart/pkg/compiler/lib/src/resolution/members.dart b/dart/pkg/compiler/lib/src/resolution/members.dart
index db2136444d096610584af5ace3e6b3fa671a2384..7f4edc20b71134442135500781fa9dc5d3590366 100644
--- a/dart/pkg/compiler/lib/src/resolution/members.dart
+++ b/dart/pkg/compiler/lib/src/resolution/members.dart
@@ -743,7 +743,8 @@ class ResolverTask extends CompilerTask {
Element nextTarget = target.immediateRedirectionTarget;
if (seen.contains(nextTarget)) {
error(node, MessageKind.CYCLIC_REDIRECTING_FACTORY);
- return;
+ targetType = target.enclosingClass.thisType;
+ break;
}
seen.add(target);
target = nextTarget;
@@ -3150,7 +3151,6 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
}
if (redirectionTarget == constructor) {
compiler.reportError(node, MessageKind.CYCLIC_REDIRECTING_FACTORY);
- return;
}
}
@@ -4257,6 +4257,9 @@ class ClassResolverVisitor extends TypeDefinitionVisitor {
}
FunctionElement constructor =
new SynthesizedConstructorElementX.forDefault(superMember, element);
+ if (superMember.isErroneous) {
+ compiler.elementsWithCompileTimeErrors.add(constructor);
+ }
element.setDefaultConstructor(constructor, compiler);
}
return element.computeType(compiler);
« no previous file with comments | « dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart ('k') | dart/pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698