Begin migrating the vm service from a rest-style interface to a json-rpc style interface.

Begin migrating the vm service from a rest-style interface to a json-rpc style interface.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=43370

[turnidge, 2015-01-14 20:57:18]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2015-02-02 22:20:04]

LGTMwC

https://codereview.chromium.org/823403004/diff/140001/runtime/bin/vmservice/v...
File runtime/bin/vmservice/vmservice_dartium.dart (right):

https://codereview.chromium.org/823403004/diff/140001/runtime/bin/vmservice/v...
runtime/bin/vmservice/vmservice_dartium.dart:1: // Copyright (c) 2013, the Dart
project authors.  Please see the AUTHORS file
This whole file can be killed now.

https://codereview.chromium.org/823403004/diff/140001/runtime/observatory/lib...
File runtime/observatory/lib/service_common.dart (right):

https://codereview.chromium.org/823403004/diff/140001/runtime/observatory/lib...
runtime/observatory/lib/service_common.dart:293: Logger.root.info('GET
${request.method} from ${target.networkAddress}');
Should this be removed?

https://codereview.chromium.org/823403004/diff/140001/runtime/observatory/lib...
File runtime/observatory/lib/service_html.dart (right):

https://codereview.chromium.org/823403004/diff/140001/runtime/observatory/lib...
runtime/observatory/lib/service_html.dart:63: class PostMessageVM extends VM {
This whole class should die now.

https://codereview.chromium.org/823403004/diff/140001/runtime/observatory/lib...
File runtime/observatory/lib/src/app/page.dart (right):

https://codereview.chromium.org/823403004/diff/140001/runtime/observatory/lib...
runtime/observatory/lib/src/app/page.dart:156: // isolate url.
Maybe this stripping of isolate out of the URL should be factored out into an
abstract IsolatePage that already has the isolate extracted.

https://codereview.chromium.org/823403004/diff/140001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/823403004/diff/140001/runtime/vm/service.cc#n...
runtime/vm/service.cc:1395: // Closure ids look like: "classes/17/closures/11"
I wonder if this function could be split up into smaller pieces?

[turnidge, 2015-02-02 22:44:06]

https://codereview.chromium.org/823403004/diff/140001/runtime/bin/vmservice/v...
File runtime/bin/vmservice/vmservice_dartium.dart (right):

https://codereview.chromium.org/823403004/diff/140001/runtime/bin/vmservice/v...
runtime/bin/vmservice/vmservice_dartium.dart:1: // Copyright (c) 2013, the Dart
project authors.  Please see the AUTHORS file
On 2015/02/02 22:20:04, Cutch wrote:
> This whole file can be killed now.

Done.

https://codereview.chromium.org/823403004/diff/140001/runtime/observatory/lib...
File runtime/observatory/lib/service_common.dart (right):

https://codereview.chromium.org/823403004/diff/140001/runtime/observatory/lib...
runtime/observatory/lib/service_common.dart:293: Logger.root.info('GET
${request.method} from ${target.networkAddress}');
On 2015/02/02 22:20:04, Cutch wrote:
> Should this be removed?

This logging was in the original.  Also, pretty useful to me.

https://codereview.chromium.org/823403004/diff/140001/runtime/observatory/lib...
File runtime/observatory/lib/service_html.dart (right):

https://codereview.chromium.org/823403004/diff/140001/runtime/observatory/lib...
runtime/observatory/lib/service_html.dart:63: class PostMessageVM extends VM {
On 2015/02/02 22:20:04, Cutch wrote:
> This whole class should die now.

Done.

https://codereview.chromium.org/823403004/diff/140001/runtime/observatory/lib...
File runtime/observatory/lib/src/app/page.dart (right):

https://codereview.chromium.org/823403004/diff/140001/runtime/observatory/lib...
runtime/observatory/lib/src/app/page.dart:156: // isolate url.
On 2015/02/02 22:20:04, Cutch wrote:
> Maybe this stripping of isolate out of the URL should be factored out into an
> abstract IsolatePage that already has the isolate extracted.

Added TODO.  I'll be touching this code again soon.

https://codereview.chromium.org/823403004/diff/140001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/823403004/diff/140001/runtime/vm/service.cc#n...
runtime/vm/service.cc:1395: // Closure ids look like: "classes/17/closures/11"
On 2015/02/02 22:20:04, Cutch wrote:
> I wonder if this function could be split up into smaller pieces?

Done.

[turnidge, 2015-02-02 23:16:27]

Committed patchset #10 (id:180001) manually as 43370 (presubmit successful).