Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Unified Diff: runtime/observatory/lib/src/elements/class_view.dart

Issue 823403004: Begin migrating the vm service from a rest-style interface to a json-rpc style interface. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: remove old-style standalone tests. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/app/page.dart ('k') | runtime/observatory/lib/src/elements/cpu_profile.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/class_view.dart
diff --git a/runtime/observatory/lib/src/elements/class_view.dart b/runtime/observatory/lib/src/elements/class_view.dart
index e9e08d5179d7134f12d9d8dad58339aeafe537e5..ac49f7ab6c2b607ce424fd64199fbaf2bfc2dcaa 100644
--- a/runtime/observatory/lib/src/elements/class_view.dart
+++ b/runtime/observatory/lib/src/elements/class_view.dart
@@ -17,15 +17,14 @@ class ClassViewElement extends ObservatoryElement {
@observable ObservableList mostRetained;
ClassViewElement.created() : super.created();
- Future<ServiceObject> eval(String text) {
- return cls.get("eval?expr=${Uri.encodeComponent(text)}");
+ Future<ServiceObject> eval(String expression) {
+ return cls.isolate.eval(cls, expression);
}
Future<ServiceObject> reachable(var limit) {
- return cls.get("instances?limit=$limit")
- .then((ServiceMap obj) {
- instances = obj;
- });
+ return cls.isolate.getInstances(cls, limit).then((ServiceMap obj) {
+ instances = obj;
+ });
}
Future<ServiceObject> retainedToplist(var limit) {
@@ -40,7 +39,7 @@ class ClassViewElement extends ObservatoryElement {
// TODO(koda): Add no-arg "calculate-link" instead of reusing "eval-link".
Future<ServiceObject> retainedSize(var dummy) {
- return cls.get("retained").then((Instance obj) {
+ return cls.isolate.getRetainedSize(cls).then((Instance obj) {
retainedBytes = int.parse(obj.valueAsString);
});
}
« no previous file with comments | « runtime/observatory/lib/src/app/page.dart ('k') | runtime/observatory/lib/src/elements/cpu_profile.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698