Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: runtime/vm/json_stream.h

Issue 823403004: Begin migrating the vm service from a rest-style interface to a json-rpc style interface. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: remove old-style standalone tests. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger_test.cc ('k') | runtime/vm/json_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/json_stream.h
diff --git a/runtime/vm/json_stream.h b/runtime/vm/json_stream.h
index 8b4fc1e842e0753c9c845fc00a8c78652c826d73..56ecbcc7df3fd25e8abdb7f9776dd3dd7c75a3ce 100644
--- a/runtime/vm/json_stream.h
+++ b/runtime/vm/json_stream.h
@@ -34,6 +34,13 @@ class JSONStream : ValueObject {
const GrowableObjectArray& path,
const Array& option_keys,
const Array& option_values);
+
+ void SetupNew(Zone* zone,
+ Dart_Port reply_port,
+ const String& method,
+ const Array& param_keys,
+ const Array& param_values);
+
void PostReply();
TextBuffer* buffer() { return &buffer_; }
@@ -50,6 +57,9 @@ class JSONStream : ValueObject {
const char* GetArgument(intptr_t i) const {
return arguments_[i];
}
+
+ // TODO(turnidge): Rename "options" to "params". That is the more
+ // appropriate name for json rpc.
intptr_t num_options() const { return num_options_; }
const char* GetOptionKey(intptr_t i) const {
return option_keys_[i];
@@ -66,6 +76,7 @@ class JSONStream : ValueObject {
// otherwise.
bool OptionIs(const char* key, const char* value) const;
+ // TODO(turnidge): Rename "command" to "method". Better name for json rpc.
const char* command() const { return command_; }
const char** arguments() const { return arguments_; }
const char** option_keys() const { return option_keys_; }
« no previous file with comments | « runtime/vm/debugger_test.cc ('k') | runtime/vm/json_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698