runtime/observatory/lib/src/elements/instance_view.dart - Issue 823403004: Begin migrating the vm service from a rest-style interface to a json-rpc style interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/instance_view.dart

Issue 823403004: Begin migrating the vm service from a rest-style interface to a json-rpc style interface. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: remove old-style standalone tests. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/lib/src/elements/heap_profile.dart ('k') | runtime/observatory/lib/src/elements/isolate_summary.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/lib/src/elements/instance_view.dart

diff --git a/runtime/observatory/lib/src/elements/instance_view.dart b/runtime/observatory/lib/src/elements/instance_view.dart

index 556a279a752927bbf9a1b1ccbb8628ffedf689a2..96598c78a5124e596f2c6bd93fab031db3cadd0d 100644

--- a/runtime/observatory/lib/src/elements/instance_view.dart

+++ b/runtime/observatory/lib/src/elements/instance_view.dart

@@ -15,9 +15,8 @@ class InstanceViewElement extends ObservatoryElement {

InstanceViewElement.created() : super.created();

- Future<ServiceObject> eval(String text) {

- return instance.isolate.get(

- instance.id + "/eval?expr=${Uri.encodeComponent(text)}");

+ Future<ServiceObject> eval(String expression) {

+ return instance.isolate.eval(instance, expression);

}

void refresh(Function onDone) {