Move elementAccess() from namer to emitter.

Move elementAccess from namer to emitter.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42130

[zarah, 2014-12-03 11:49:22]

Patchset #1 (id:1) has been deleted

[zarah, 2014-12-03 13:40:35]

Patchset #1 (id:20001) has been deleted

[zarah, 2014-12-03 13:49:30]

Patchset #1 (id:40001) has been deleted

[zarah, 2014-12-03 14:03:33]

zarah@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2014-12-03 17:02:27]

LGTM.
I would try to differentiate the different accesses.
I gave a few suggestions, but they are not completely consistent.

I think we should not make the distinction between classAccess and
jsConstructorAccess. (We have too many assumptions that they are the same).

Probably the easiest is to go with classAccess and add a comment that it
represents the js-constructor which must have a .prototype.
Up to you if you want to have a jsPrototypeAccess.

Ideally we can type the arguments for these accesses differently.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/backend.dart:2124: jsAst.Expression
helperExpression = emitter.globalPropertyAccess(helper);
Let's make the distinction between static functions and classes:
emitter.staticFunctionAccess(helper).

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart:26:
codegen.backend.emitter.globalPropertyAccess(helperElement);
ditto (staticFunctionAccess)

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:174: js.Expression
elementAccess = glue.globalPropertyAccess(target);
ditto: staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/constant_emitter.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/constant_emitter.dart:243: return
backend.emitter.globalPropertyAccess(element);
emitter.constructorAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/constant_emitter.dart:325: return
backend.emitter.globalPropertyAccess(helper);
staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/native_emitter.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/native_emitter.dart:44: return
emitterTask.globalPropertyAccess(element);
staticFunction

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/native_emitter.dart:340:
emitterTask.globalPropertyAccess(converter);
staticFunction

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/runtime_types.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/runtime_types.dart:542: [
backend.emitter.globalPropertyAccess(backend.getComputeSignature()),
I'm guessing staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/runtime_types.dart:634: return
backend.emitter.globalPropertyAccess(element);
I'm not sure what the element is here, and how it should be used.
maybe constructorAccess.
maybe classAccess.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart:16: return
js('#.prototype', backend.emitter.globalPropertyAccess(cls));
classAccess
Maybe even classPrototypeAccess

Interestingly we needed to add "eager" classes because of the interceptors.
If we change the way we access classPrototypes we could potentially remove the
eager classes again.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart:145:
backend.emitter.globalPropertyAccess(compiler.objectClass),
either classAccess or constructorAccess.
Both make sense:
- classAccess, because we make an is-check.
- constructorAccess, because that's what we have to use in JS to do an is-check.

Almost leaning towards constructorAccess.
Also: should probably be jsConstructorAccess.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart:146:
backend.emitter.globalPropertyAccess(backend.getNativeInterceptorMethod)]));
staticFunctionAccess.

Long line.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart:154:
[backend.emitter.globalPropertyAccess(compiler.objectClass),
as in line 145.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart:75: // TODO(zarah):
copied from OldEmitter. Adjust or share.
No need to share.
This is small enough and emitter specific.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:84:
backend.emitter.globalPropertyAccess(backend.getCyclicThrowHelper()),
staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart:603:
globalPropertyAccess(backend.findHelper('convertRtiToRuntimeType'));
staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:129:
[backend.emitter.globalPropertyAccess(superClass), methodName,
prototypeAccess or classAccess.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:138:
[emitter.globalPropertyAccess(member), argumentsBuffer]);
staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:657:
globalPropertyAccess(backend.getCyclicThrowHelper());
staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1054:
[backend.emitter.globalPropertyAccess(isolateMain), mainAccess]);
staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1128:
backend.emitter.globalPropertyAccess(main));
staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1130: mainCallClosure =
backend.emitter.globalPropertyAccess(main);
staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/interceptor_emitter.dart
(right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/interceptor_emitter.dart:115:
elements.add(backend.emitter.globalPropertyAccess(classElement));
constructorAccess.
I think.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/interceptor_emitter.dart:137:
backend.emitter.globalPropertyAccess(member)));
constructorAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:86:
backend.emitter.globalPropertyAccess(
I think staticFunctionAccess.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:274:
globalPropertyAccess(backend.getCreateInvocationMirror());
I prefer to put the "." on the second line:
 .globalPropertyAccess

I think staticFunctionAccess.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
(right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart:322:
backend.emitter.globalPropertyAccess(closureFromTearOff);
staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart:227:
jsAst.Expression holder = backend.emitter.globalPropertyAccess(cls);
classAccess or jsConstructorAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/program_builder.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/program_builder.dart:119:
backend.emitter.globalPropertyAccess(_compiler.mainFunction),
staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/builder.dart:3762:
backend.emitter.globalPropertyAccess(element)),
Not 100% sure.
I believe it's a staticFunction, but maybe a closureAccess.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/builder.dart:3805:
backend.emitter.globalPropertyAccess(
jsConstructorAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
File pkg/compiler/lib/src/ssa/codegen.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:1644:
push(backend.emitter.globalPropertyAccess(node.element));
staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:1685:
[backend.emitter.globalPropertyAccess(superClass),
jsConstructorAccess
oder
prototypeAccess (since we are going to the prototype).

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:1789:
backend.emitter.globalPropertyAccess(node.element);
jsConstructorAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2027: js.Expression jsHelper =
backend.emitter.globalPropertyAccess(helper);
staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2060: js.Expression jsHelper =
backend.emitter.globalPropertyAccess(helper);
staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2075:
push(backend.emitter.globalPropertyAccess(node.element));
not sure.
I don't think it's a staticFunctionAccess, but I'm not sure.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2091: js.Node variable =
backend.emitter.globalPropertyAccess(node.element);
staticFieldAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2123:
backend.emitter.globalPropertyAccess(convertToString);
staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2678: js.Expression helper =
backend.emitter.globalPropertyAccess(helperElement);
staticFunctionAccess

long line.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2688:
backend.emitter.globalPropertyAccess(
staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2702: var arguments =
[backend.emitter.globalPropertyAccess(cls)];
classAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2724: return
backend.emitter.globalPropertyAccess(helper);
staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
File pkg/dart2js_incremental/lib/library_updater.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:579: jsAst.Node classAccess =
emitter.globalPropertyAccess(cls);
classAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:588: jsAst.Node superAccess =
emitter.globalPropertyAccess(superclass);
classAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:605: :
emitter.globalPropertyAccess(superclass);
classAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:606: jsAst.Node classAccess =
emitter.globalPropertyAccess(cls);
classAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:662:
emitter.globalPropertyAccess(element.enclosingClass));
classAccess, jsConstructorAccess, or prototypeAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:811: elementAccess =
emitter.globalPropertyAccess(element.enclosingClass);
classAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:814: elementAccess =
emitter.globalPropertyAccess(element);
I believe staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:860:
accessToStatics.add(emitter.globalPropertyAccess(element));
not sure.
probably classAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:864:
accessToStatics.add(emitter.globalPropertyAccess(member));
staticFunctionAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:921: elementAccess =
emitter.globalPropertyAccess(element.enclosingClass);
classAccess

[zarah, 2014-12-05 08:22:52]

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/backend.dart:2124: jsAst.Expression
helperExpression = emitter.globalPropertyAccess(helper);
On 2014/12/03 17:02:24, floitsch wrote:
> Let's make the distinction between static functions and classes:
> emitter.staticFunctionAccess(helper).

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart:26:
codegen.backend.emitter.globalPropertyAccess(helperElement);
On 2014/12/03 17:02:24, floitsch wrote:
> ditto (staticFunctionAccess)

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:174: js.Expression
elementAccess = glue.globalPropertyAccess(target);
On 2014/12/03 17:02:24, floitsch wrote:
> ditto: staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/constant_emitter.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/constant_emitter.dart:243: return
backend.emitter.globalPropertyAccess(element);
On 2014/12/03 17:02:24, floitsch wrote:
> emitter.constructorAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/constant_emitter.dart:325: return
backend.emitter.globalPropertyAccess(helper);
On 2014/12/03 17:02:24, floitsch wrote:
> staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/native_emitter.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/native_emitter.dart:44: return
emitterTask.globalPropertyAccess(element);
On 2014/12/03 17:02:24, floitsch wrote:
> staticFunction

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/native_emitter.dart:340:
emitterTask.globalPropertyAccess(converter);
On 2014/12/03 17:02:24, floitsch wrote:
> staticFunction

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_backend/runtime_types.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/runtime_types.dart:542: [
backend.emitter.globalPropertyAccess(backend.getComputeSignature()),
On 2014/12/03 17:02:25, floitsch wrote:
> I'm guessing staticFunctionAccess

Yes, Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_backend/runtime_types.dart:634: return
backend.emitter.globalPropertyAccess(element);
On 2014/12/03 17:02:25, floitsch wrote:
> I'm not sure what the element is here, and how it should be used.
> maybe constructorAccess.
> maybe classAccess.

classAccess and typedefAccess

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart:16: return
js('#.prototype', backend.emitter.globalPropertyAccess(cls));
On 2014/12/03 17:02:25, floitsch wrote:
> classAccess
> Maybe even classPrototypeAccess
> 
> Interestingly we needed to add "eager" classes because of the interceptors.
> If we change the way we access classPrototypes we could potentially remove the
> eager classes again.

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart:145:
backend.emitter.globalPropertyAccess(compiler.objectClass),
On 2014/12/03 17:02:25, floitsch wrote:
> either classAccess or constructorAccess.
> Both make sense:
> - classAccess, because we make an is-check.
> - constructorAccess, because that's what we have to use in JS to do an
is-check.
> 
> Almost leaning towards constructorAccess.
> Also: should probably be jsConstructorAccess.

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart:146:
backend.emitter.globalPropertyAccess(backend.getNativeInterceptorMethod)]));
On 2014/12/03 17:02:25, floitsch wrote:
> staticFunctionAccess.
> 
> Long line.

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart:154:
[backend.emitter.globalPropertyAccess(compiler.objectClass),
On 2014/12/03 17:02:25, floitsch wrote:
> as in line 145.

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart:75: // TODO(zarah):
copied from OldEmitter. Adjust or share.
On 2014/12/03 17:02:25, floitsch wrote:
> No need to share.
> This is small enough and emitter specific.

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart:84:
backend.emitter.globalPropertyAccess(backend.getCyclicThrowHelper()),
On 2014/12/03 17:02:25, floitsch wrote:
> staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart:603:
globalPropertyAccess(backend.findHelper('convertRtiToRuntimeType'));
On 2014/12/03 17:02:25, floitsch wrote:
> staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:129:
[backend.emitter.globalPropertyAccess(superClass), methodName,
On 2014/12/03 17:02:25, floitsch wrote:
> prototypeAccess or classAccess.

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart:138:
[emitter.globalPropertyAccess(member), argumentsBuffer]);
On 2014/12/03 17:02:25, floitsch wrote:
> staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:657:
globalPropertyAccess(backend.getCyclicThrowHelper());
On 2014/12/03 17:02:25, floitsch wrote:
> staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1054:
[backend.emitter.globalPropertyAccess(isolateMain), mainAccess]);
On 2014/12/03 17:02:25, floitsch wrote:
> staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1128:
backend.emitter.globalPropertyAccess(main));
On 2014/12/03 17:02:25, floitsch wrote:
> staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:1130: mainCallClosure =
backend.emitter.globalPropertyAccess(main);
On 2014/12/03 17:02:25, floitsch wrote:
> staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/interceptor_emitter.dart
(right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/interceptor_emitter.dart:115:
elements.add(backend.emitter.globalPropertyAccess(classElement));
On 2014/12/03 17:02:25, floitsch wrote:
> constructorAccess.
> I think.

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/interceptor_emitter.dart:137:
backend.emitter.globalPropertyAccess(member)));
On 2014/12/03 17:02:25, floitsch wrote:
> constructorAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:86:
backend.emitter.globalPropertyAccess(
On 2014/12/03 17:02:25, floitsch wrote:
> I think staticFunctionAccess.

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart:274:
globalPropertyAccess(backend.getCreateInvocationMirror());
On 2014/12/03 17:02:25, floitsch wrote:
> I prefer to put the "." on the second line:
>  .globalPropertyAccess
> 
> I think staticFunctionAccess.

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
(right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart:322:
backend.emitter.globalPropertyAccess(closureFromTearOff);
On 2014/12/03 17:02:25, floitsch wrote:
> staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart:227:
jsAst.Expression holder = backend.emitter.globalPropertyAccess(cls);
On 2014/12/03 17:02:26, floitsch wrote:
> classAccess or jsConstructorAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/program_builder.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/program_builder.dart:119:
backend.emitter.globalPropertyAccess(_compiler.mainFunction),
On 2014/12/03 17:02:26, floitsch wrote:
> staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/builder.dart:3762:
backend.emitter.globalPropertyAccess(element)),
On 2014/12/03 17:02:26, floitsch wrote:
> Not 100% sure.
> I believe it's a staticFunction, but maybe a closureAccess.

Yes, Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/builder.dart:3805:
backend.emitter.globalPropertyAccess(
On 2014/12/03 17:02:26, floitsch wrote:
> jsConstructorAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
File pkg/compiler/lib/src/ssa/codegen.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:1644:
push(backend.emitter.globalPropertyAccess(node.element));
On 2014/12/03 17:02:26, floitsch wrote:
> staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:1685:
[backend.emitter.globalPropertyAccess(superClass),
On 2014/12/03 17:02:26, floitsch wrote:
> jsConstructorAccess
> oder
> prototypeAccess (since we are going to the prototype).

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:1789:
backend.emitter.globalPropertyAccess(node.element);
On 2014/12/03 17:02:26, floitsch wrote:
> jsConstructorAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2027: js.Expression jsHelper =
backend.emitter.globalPropertyAccess(helper);
On 2014/12/03 17:02:26, floitsch wrote:
> staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2060: js.Expression jsHelper =
backend.emitter.globalPropertyAccess(helper);
On 2014/12/03 17:02:26, floitsch wrote:
> staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2075:
push(backend.emitter.globalPropertyAccess(node.element));
On 2014/12/03 17:02:26, floitsch wrote:
> not sure.
> I don't think it's a staticFunctionAccess, but I'm not sure.

FieldAccess.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2091: js.Node variable =
backend.emitter.globalPropertyAccess(node.element);
On 2014/12/03 17:02:26, floitsch wrote:
> staticFieldAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2123:
backend.emitter.globalPropertyAccess(convertToString);
On 2014/12/03 17:02:26, floitsch wrote:
> staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2678: js.Expression helper =
backend.emitter.globalPropertyAccess(helperElement);
On 2014/12/03 17:02:26, floitsch wrote:
> staticFunctionAccess
> 
> long line.

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2688:
backend.emitter.globalPropertyAccess(
On 2014/12/03 17:02:26, floitsch wrote:
> staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2702: var arguments =
[backend.emitter.globalPropertyAccess(cls)];
On 2014/12/03 17:02:26, floitsch wrote:
> classAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/codegen.dart:2724: return
backend.emitter.globalPropertyAccess(helper);
On 2014/12/03 17:02:26, floitsch wrote:
> staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
File pkg/dart2js_incremental/lib/library_updater.dart (right):

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:579: jsAst.Node classAccess =
emitter.globalPropertyAccess(cls);
On 2014/12/03 17:02:26, floitsch wrote:
> classAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:588: jsAst.Node superAccess =
emitter.globalPropertyAccess(superclass);
On 2014/12/03 17:02:27, floitsch wrote:
> classAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:605: :
emitter.globalPropertyAccess(superclass);
On 2014/12/03 17:02:27, floitsch wrote:
> classAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:606: jsAst.Node classAccess =
emitter.globalPropertyAccess(cls);
On 2014/12/03 17:02:27, floitsch wrote:
> classAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:662:
emitter.globalPropertyAccess(element.enclosingClass));
On 2014/12/03 17:02:27, floitsch wrote:
> classAccess, jsConstructorAccess, or prototypeAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:811: elementAccess =
emitter.globalPropertyAccess(element.enclosingClass);
On 2014/12/03 17:02:26, floitsch wrote:
> classAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:814: elementAccess =
emitter.globalPropertyAccess(element);
On 2014/12/03 17:02:26, floitsch wrote:
> I believe staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:860:
accessToStatics.add(emitter.globalPropertyAccess(element));
On 2014/12/03 17:02:26, floitsch wrote:
> not sure.
> probably classAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:864:
accessToStatics.add(emitter.globalPropertyAccess(member));
On 2014/12/03 17:02:26, floitsch wrote:
> staticFunctionAccess

Done.

https://codereview.chromium.org/779593002/diff/60001/pkg/dart2js_incremental/...
pkg/dart2js_incremental/lib/library_updater.dart:921: elementAccess =
emitter.globalPropertyAccess(element.enclosingClass);
On 2014/12/03 17:02:27, floitsch wrote:
> classAccess

Done.

[zarah, 2014-12-05 08:30:34]

Committed patchset #2 (id:80001) manually as 42130 (presubmit successful).

[ahe, 2014-12-09 11:30:22]

ahe@google.com changed reviewers:
+ ahe@google.com

[ahe, 2014-12-09 11:30:23]

I would appreciate being CC'ed when you make changes to the incremental
compiler.