Move elementAccess() from namer to emitter.

pkg/compiler/lib/src/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 class SsaFunctionCompiler implements FunctionCompiler {
   SsaCodeGeneratorTask generator;
   SsaBuilderTask builder;
   SsaOptimizerTask optimizer;
@@ skipping 3741 matching lines @@
     // signatures have different elements for parameters.
     FunctionElement implementation = function.implementation;
     FunctionSignature params = implementation.functionSignature;
     if (params.optionalParameterCount != 0) {
       compiler.internalError(closure,
           '"$name" does not handle closure with optional parameters.');
     }
 
     registry.registerStaticUse(element);
     push(new HForeign(js.js.expressionTemplateYielding(
-                          backend.namer.elementAccess(element)),
+                          backend.emitter.globalPropertyAccess(element)),

[floitsch, 2014/12/03 17:02:26]

Not 100% sure.
I believe it's a staticFunction, but maybe a closureAccess.

[zarah, 2014/12/05 08:22:51]

Yes, Done.

                       backend.dynamicType,
                       <HInstruction>[]));
     return params;
   }
 
   void handleForeignDartClosureToJs(ast.Send node, String name) {
     // TODO(ahe): This implements DART_CLOSURE_TO_JS and should probably take
     // care to wrap the closure in another closure that saves the current
     // isolate.
     handleForeignRawFunctionRef(node, name);
@@ skipping 22 matching lines @@
     push(new HForeign(js.js.parseForeignJS("new $constructorName()"),
                       backend.dynamicType,
                       <HInstruction>[]));
   }
 
   void handleForeignDartObjectJsConstructorFunction(ast.Send node) {
     if (!node.arguments.isEmpty) {
       compiler.internalError(node.argumentsNode, 'Too many arguments.');
     }
     push(new HForeign(js.js.expressionTemplateYielding(
-                          backend.namer.elementAccess(compiler.objectClass)),
+                          backend.emitter.globalPropertyAccess(

[floitsch, 2014/12/03 17:02:26]

jsConstructorAccess

[zarah, 2014/12/05 08:22:51]

Done.

+                              compiler.objectClass)),
                       backend.dynamicType,
                       <HInstruction>[]));
   }
 
   void handleForeignJsCurrentIsolate(ast.Send node) {
     if (!node.arguments.isEmpty) {
       compiler.internalError(node.argumentsNode, 'Too many arguments.');
     }
     push(new HForeign(js.js.parseForeignJS(backend.namer.currentIsolate),
                       backend.dynamicType,
@@ skipping 2806 matching lines @@
     if (unaliased is TypedefType) throw 'unable to unalias $type';
     unaliased.accept(this, builder);
   }
 
   void visitDynamicType(DynamicType type, SsaBuilder builder) {
     JavaScriptBackend backend = builder.compiler.backend;
     ClassElement cls = backend.findHelper('DynamicRuntimeType');
     builder.push(new HDynamicType(type, new TypeMask.exact(cls, classWorld)));
   }
 }