Move elementAccess() from namer to emitter.

pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.js_emitter;
 
 class NsmEmitter extends CodeEmitterHelper {
   final List<Selector> trivialNsmHandlers = <Selector>[];
 
   /// If this is true then we can generate the noSuchMethod handlers at startup
@@ skipping 65 matching lines @@
       if (!haveVeryFewNoSuchMemberHandlers &&
           isTrivialNsmHandler(type, argNames, selector, internalName) &&
           reflectionName == null) {
         trivialNsmHandlers.add(selector);
         return null;
       }
 
       assert(backend.isInterceptedName(Compiler.NO_SUCH_METHOD));
       jsAst.Expression expression = js('this.#(this, #(#, #, #, #, #))', [
           noSuchMethodName,
-          namer.elementAccess(backend.getCreateInvocationMirror()),
+          backend.emitter.globalPropertyAccess(

[floitsch, 2014/12/03 17:02:25]

I think staticFunctionAccess.

[zarah, 2014/12/05 08:22:51]

Done.

+              backend.getCreateInvocationMirror()),
           js.string(compiler.enableMinification ?
               internalName : methodName),
           js.string(internalName),
           js.number(type),
           new jsAst.ArrayInitializer(parameterNames.map(js).toList()),
           new jsAst.ArrayInitializer(argNames)]);
 
       if (backend.isInterceptedName(selector.name)) {
         return js(r'function($receiver, #) { return # }',
                   [parameterNames, expression]);
@@ skipping 165 matching lines @@
           diffEncoding.write(",");
         }
         diffEncoding.write(short);
       }
       nameCounter++;
     }
 
     // Startup code that loops over the method names and puts handlers on the
     // Object class to catch noSuchMethod invocations.
     ClassElement objectClass = compiler.objectClass;
-    jsAst.Expression createInvocationMirror = namer.elementAccess(
-        backend.getCreateInvocationMirror());
+    jsAst.Expression createInvocationMirror = backend.emitter.
+        globalPropertyAccess(backend.getCreateInvocationMirror());

[floitsch, 2014/12/03 17:02:25]

I prefer to put the "." on the second line:
 .globalPropertyAccess

I think staticFunctionAccess.

[zarah, 2014/12/05 08:22:51]

Done.

     String noSuchMethodName = namer.publicInstanceMethodNameByArity(
         Compiler.NO_SUCH_METHOD, Compiler.NO_SUCH_METHOD_ARG_COUNT);
     var type = 0;
     if (useDiffEncoding) {
       statements.add(js.statement('''{
           var objectClassObject =
                   collectedClasses[#],    // # is name of class Object.
               shortNames = #.split(","),  // # is diffEncoding.
               nameNumber = 0,
               diffEncodedString = shortNames[0],
@@ skipping 95 matching lines @@
           noSuchMethodName,
           createInvocationMirror,
           sliceOffsetParams,  // argument to slice
           minify ? 'shortNames' : 'longNames',
           sliceOffsetArguments
       ]));
 
     return statements;
   }
 }