Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

Issue 779593002: Move elementAccess() from namer to emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.new_js_emitter.emitter; 5 library dart2js.new_js_emitter.emitter;
6 6
7 import '../model.dart'; 7 import '../model.dart';
8 import 'model_emitter.dart'; 8 import 'model_emitter.dart';
9 import '../../common.dart'; 9 import '../../common.dart';
10 import '../../js/js.dart' as js; 10 import '../../js/js.dart' as js;
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 65
66 js.Expression generateEmbeddedGlobalAccess(String global) { 66 js.Expression generateEmbeddedGlobalAccess(String global) {
67 // TODO(floitsch): We should not use "init" for globals. 67 // TODO(floitsch): We should not use "init" for globals.
68 return js.string("init.$global"); 68 return js.string("init.$global");
69 } 69 }
70 70
71 js.Expression constantReference(ConstantValue value) { 71 js.Expression constantReference(ConstantValue value) {
72 return _emitter.constantEmitter.reference(value); 72 return _emitter.constantEmitter.reference(value);
73 } 73 }
74 74
75 // TODO(zarah): copied from OldEmitter. Adjust or share.
floitsch 2014/12/03 17:02:25 No need to share. This is small enough and emitter
zarah 2014/12/05 08:22:51 Done.
76 js.PropertyAccess globalPropertyAccess(Element element) {
77 String name = namer.getNameX(element);
78 js.PropertyAccess pa = new js.PropertyAccess.field(
79 new js.VariableUse(namer.globalObjectFor(element)),
80 name);
81 return pa;
82 }
83
75 void invalidateCaches() {} 84 void invalidateCaches() {}
76 } 85 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698