- Ensure that classes are finalized before their description is

- Ensure that classes are finalized before their description is
  being generated for the observatory.
- Reset the state that a class is being currently parsed.
- Move the deployed polymer app to a location where it is not
  being overwritten by the tools.
- Do not rely on Dart SDK binaries being in your path.
- Check for errors when invoking dart2js as part of build.dart.

Committed: https://code.google.com/p/dart/source/detail?r=30533

[Cutch, 2013-11-21 14:50:07]

https://codereview.chromium.org/77043010/diff/330001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/77043010/diff/330001/runtime/vm/object.cc#new...
runtime/vm/object.cc:10633: jsobj.AddProperty("type", JSONType(ref));
We end up sending a reference (@LanguageError) to the error message with no way
to create a link back to the error (no id for the error object). Better to
write:

jsobj.AddProperty("type", JSONType(ref));
jsobj.AddProperty("error_msg", ToErrorCString());
if (ref) {
  jsobj.AddProperty("id",
Isolate::Current()->object_id_ring()->GetIdForObject(raw());
}

https://codereview.chromium.org/77043010/diff/330001/runtime/vm/object.cc#new...
runtime/vm/object.cc:10680: jsobj.AddProperty("type", JSONType(ref));
ditto and the other errors.

[Ivan Posva, 2013-11-21 17:23:51]

https://codereview.chromium.org/77043010/diff/330001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/77043010/diff/330001/runtime/vm/object.cc#new...
runtime/vm/object.cc:10633: jsobj.AddProperty("type", JSONType(ref));
On 2013/11/21 14:50:07, Cutch wrote:
> We end up sending a reference (@LanguageError) to the error message with no
way
> to create a link back to the error (no id for the error object). Better to
> write:
> 
> jsobj.AddProperty("type", JSONType(ref));
> jsobj.AddProperty("error_msg", ToErrorCString());
> if (ref) {
>   jsobj.AddProperty("id",
> Isolate::Current()->object_id_ring()->GetIdForObject(raw());
> }

As discussed I changed this to not send a reference, but the "full" error
always.

[Ivan Posva, 2013-11-21 17:26:33]

Committed patchset #4 manually as r30533 (presubmit successful).

[Cutch, 2013-11-21 17:26:58]

lgtm

[siva, 2013-11-21 19:11:18]

LGTM with one comment about the side effect of browsing compiling the class,
this may not be desired in most cases.

https://codereview.chromium.org/77043010/diff/890001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/77043010/diff/890001/runtime/vm/object.cc#new...
runtime/vm/object.cc:3237: }
This now means classes which have not been compiled yet will start getting
compiled just because they are being browsed, i.e browsing has a side effect
here.

Do we want to instead just state that the class is not finalized and provide an
option to explode the class only if the user decides to do so?

[Bob Nystrom, 2013-11-21 21:23:52]

https://codereview.chromium.org/77043010/diff/890001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/build.dart (right):

https://codereview.chromium.org/77043010/diff/890001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/build.dart:16: var dart_path = Platform.executable;
Drive-by comment: The style guide for variables in Dart code is camelCase, not
underscore_separated.