runtime/bin/vmservice/client/build.dart - Issue 77043010: - Ensure that classes are finalized before their description is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/build.dart

Issue 77043010: - Ensure that classes are finalized before their description is (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/vmservice/client/build.dart

===================================================================

--- runtime/bin/vmservice/client/build.dart (revision 30528)

+++ runtime/bin/vmservice/client/build.dart (working copy)

@@ -13,10 +13,18 @@

compileToJs(_) {

print("Running dart2js");

+ var dart_path = Platform.executable;

Bob Nystrom 2013/11/21 21:23:53 Drive-by comment: The style guide for variables in

+ var bin_path = dart_path.substring(0, dart_path.lastIndexOf(Platform.pathSeparator));

+ var dart2js_path = "$bin_path${Platform.pathSeparator}dart2js";

var result =

- Process.runSync('dart2js',

+ Process.runSync(dart2js_path,

[ '--minify', '-o', 'out/web/index.html_bootstrap.dart.js',

'out/web/index.html_bootstrap.dart'], runInShell: true);

print(result.stdout);

+ print(result.stderr);

+ if (result.exitCode != 0) {

+ print("Running dart2js failed.");

+ exit(result.exitCode);

+ }

print("Done");

}

« no previous file with comments | « runtime/bin/resources_sources.gypi ('k') | runtime/bin/vmservice/client/deployed/web/index.html » ('j') | runtime/vm/object.cc » ('J')