- Ensure that classes are finalized before their description is

runtime/vm/object.cc

Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc	(revision 30528)
+++ runtime/vm/object.cc	(working copy)
@@ -3231,6 +3231,10 @@
   jsobj.AddProperty("name", internal_class_name);
   jsobj.AddProperty("user_name", user_visible_class_name);
   if (!ref) {
+    const Error& err = Error::Handle(EnsureIsFinalized(Isolate::Current()));
+    if (!err.IsNull()) {
+      jsobj.AddProperty("error", err);
+    }

[siva, 2013/11/21 19:11:19]

This now means classes which have not been compiled yet will start getting
compiled just because they are being browsed, i.e browsing has a side effect
here.

Do we want to instead just state that the class is not finalized and provide an
option to explode the class only if the user decides to do so?

     jsobj.AddProperty("implemented", is_implemented());
     jsobj.AddProperty("abstract", is_abstract());
     jsobj.AddProperty("patch", is_patch());
@@ -10626,6 +10630,8 @@
 
 void Error::PrintToJSONStream(JSONStream* stream, bool ref) const {
   JSONObject jsobj(stream);
+  jsobj.AddProperty("type", JSONType(false));
+  jsobj.AddProperty("error_msg", ToErrorCString());
 }
 
 
@@ -10671,6 +10677,8 @@
 
 void ApiError::PrintToJSONStream(JSONStream* stream, bool ref) const {
   JSONObject jsobj(stream);
+  jsobj.AddProperty("type", JSONType(false));
+  jsobj.AddProperty("error_msg", ToErrorCString());
 }
 
 
@@ -10855,6 +10863,8 @@
 
 void LanguageError::PrintToJSONStream(JSONStream* stream, bool ref) const {
   JSONObject jsobj(stream);
+  jsobj.AddProperty("type", JSONType(false));
+  jsobj.AddProperty("error_msg", ToErrorCString());
 }
 
 
@@ -10929,6 +10939,8 @@
 void UnhandledException::PrintToJSONStream(JSONStream* stream,
                                            bool ref) const {
   JSONObject jsobj(stream);
+  jsobj.AddProperty("type", JSONType(false));
+  jsobj.AddProperty("error_msg", ToErrorCString());
 }
 
 
@@ -10965,6 +10977,8 @@
 
 void UnwindError::PrintToJSONStream(JSONStream* stream, bool ref) const {
   JSONObject jsobj(stream);
+  jsobj.AddProperty("type", JSONType(false));
+  jsobj.AddProperty("error_msg", ToErrorCString());
 }