Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/vmservice/client/deployed/web/index.html

Issue 77043010: - Ensure that classes are finalized before their description is (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/bin/vmservice/client/build.dart ('K') | « runtime/bin/vmservice/client/build.dart ('k') | runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js » ('j') | runtime/vm/object.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/client/deployed/web/index.html
===================================================================
--- runtime/bin/vmservice/client/deployed/web/index.html (revision 30485)
+++ runtime/bin/vmservice/client/deployed/web/index.html (working copy)
@@ -1,4 +1,6 @@
-<!DOCTYPE html><html><head>
+<!DOCTYPE html><html><head><script src="packages/shadow_dom/shadow_dom.debug.js"></script>
+<script src="packages/custom_element/custom-elements.debug.js"></script>
+<script src="packages/browser/interop.js"></script>
<title>Dart VM Observatory</title>
<meta charset="utf-8">
@@ -9,6 +11,25 @@
</head>
<body><polymer-element name="observatory-element">
+</polymer-element><polymer-element name="error-view" extends="observatory-element">
+ <template>
+ <div class="row">
+ <div class="col-md-8 col-md-offset-2">
+ <div class="panel panel-danger">
+ <div class="panel-heading">Error</div>
+ <div class="panel-body">
+ <template if="{{ (error_obj == null) || (error_obj['type'] != '@LanguageError') }}">
+ <p>{{ error }}</p>
+ </template>
+ <template if="{{ (error_obj != null) &amp;&amp; (error_obj['type'] == '@LanguageError') }}">
+ <pre>{{ error_obj['error_msg'] }}</pre>
+ </template>
+ </div>
+ </div>
+ </div>
+ </div>
+ </template>
+
</polymer-element><polymer-element name="class-view" extends="observatory-element">
<template>
<div class="row">
@@ -46,36 +67,41 @@
</tr>
</tbody>
</table>
- <blockquote><strong>Fields</strong></blockquote>
- <table class="table table-hover">
- <thead>
- <tr>
- <th>User Name</th>
- <th>VM Name</th>
- </tr>
- </thead>
- <tbody>
- <tr template="" repeat="{{ field in cls['fields'] }}">
- <td><a href="{{ app.locationManager.currentIsolateObjectLink(field['id'])}}">{{ field['user_name'] }}</a></td>
- <td><a href="{{ app.locationManager.currentIsolateObjectLink(field['id'])}}">{{ field['name'] }}</a></td>
- </tr>
- </tbody>
- </table>
- <blockquote><strong>Functions</strong></blockquote>
- <table class="table table-hover">
- <thead>
- <tr>
- <th>User Name</th>
- <th>VM Name</th>
- </tr>
- </thead>
- <tbody>
- <tr template="" repeat="{{ function in cls['functions'] }}">
- <td><a href="{{ app.locationManager.currentIsolateObjectLink(function['id'])}}">{{ function['user_name'] }}</a></td>
- <td><a href="{{ app.locationManager.currentIsolateObjectLink(function['id'])}}">{{ function['name'] }}</a></td>
- </tr>
- </tbody>
- </table>
+ <template if="{{ cls['error'] == null }}">
+ <blockquote><strong>Fields</strong></blockquote>
+ <table class="table table-hover">
+ <thead>
+ <tr>
+ <th>User Name</th>
+ <th>VM Name</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr template="" repeat="{{ field in cls['fields'] }}">
+ <td><a href="{{ app.locationManager.currentIsolateObjectLink(field['id'])}}">{{ field['user_name'] }}</a></td>
+ <td><a href="{{ app.locationManager.currentIsolateObjectLink(field['id'])}}">{{ field['name'] }}</a></td>
+ </tr>
+ </tbody>
+ </table>
+ <blockquote><strong>Functions</strong></blockquote>
+ <table class="table table-hover">
+ <thead>
+ <tr>
+ <th>User Name</th>
+ <th>VM Name</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr template="" repeat="{{ function in cls['functions'] }}">
+ <td><a href="{{ app.locationManager.currentIsolateObjectLink(function['id'])}}">{{ function['user_name'] }}</a></td>
+ <td><a href="{{ app.locationManager.currentIsolateObjectLink(function['id'])}}">{{ function['name'] }}</a></td>
+ </tr>
+ </tbody>
+ </table>
+ </template>
+ <template if="{{ cls['error'] != null }}">
+ <error-view error_obj="{{ cls['error'] }}"></error-view>
+ </template>
</div>
</div>
</div>
@@ -138,20 +164,6 @@
</div>
</template>
-</polymer-element><polymer-element name="error-view" extends="observatory-element">
- <template>
- <div class="row">
- <div class="col-md-8 col-md-offset-2">
- <div class="panel panel-danger">
- <div class="panel-heading">Error</div>
- <div class="panel-body">
- <p>{{ error }}</p>
- </div>
- </div>
- </div>
- </div>
- </template>
-
</polymer-element><polymer-element name="field-view" extends="observatory-element">
<template>
<div class="row">
@@ -248,7 +260,7 @@
<template>
<div class="row">
<div class="col-md-1">
- <img src="img/isolate_icon.png" class="img-polaroid">
+ <img src="packages/observatory/src/observatory_elements/img/isolate_icon.png" class="img-polaroid">
</div>
<div class="col-md-1">{{ isolate }}</div>
<div class="col-md-10">{{ name }}</div>
@@ -435,4 +447,4 @@
</polymer-element>
<observatory-application></observatory-application>
-</body></html>
+</body></html>
« runtime/bin/vmservice/client/build.dart ('K') | « runtime/bin/vmservice/client/build.dart ('k') | runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698