Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 767643002: dart2js: Make usage of names more consistent between compiler and runtime. (Closed)

Created:
6 years ago by floitsch
Modified:
6 years ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, sigurdm, Johnni Winther
Visibility:
Public.

Description

dart2js: Make usage of names more consistent between compiler and runtime. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=42025

Patch Set 1 #

Patch Set 2 : Fix long lines. #

Total comments: 4

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -66 lines) Patch
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 3 chunks +13 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 1 chunk +25 lines, -9 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/foreign_helper.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_mirrors.dart View 1 3 chunks +49 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/deferred_emit_type_checks_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 3 chunks +20 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
I still don't like how we deal with these constants, but at least it seems ...
6 years ago (2014-11-27 19:31:59 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/767643002/diff/20001/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart File sdk/lib/_internal/compiler/js_lib/js_mirrors.dart (right): https://codereview.chromium.org/767643002/diff/20001/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart#newcode27 sdk/lib/_internal/compiler/js_lib/js_mirrors.dart:27: JS_TYPEDEF_TAG, I think we should use JS_GET_NAME instead ...
6 years ago (2014-11-28 10:19:00 UTC) #3
floitsch
https://codereview.chromium.org/767643002/diff/20001/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart File sdk/lib/_internal/compiler/js_lib/js_mirrors.dart (right): https://codereview.chromium.org/767643002/diff/20001/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart#newcode27 sdk/lib/_internal/compiler/js_lib/js_mirrors.dart:27: JS_TYPEDEF_TAG, On 2014/11/28 10:19:00, karlklose wrote: > I think ...
6 years ago (2014-11-28 10:40:17 UTC) #4
floitsch
6 years ago (2014-11-28 10:40:40 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 42025 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698