Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2053)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 767643002: dart2js: Make usage of names more consistent between compiler and runtime. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index 48f9271912d57af44942d68ce4cba4436859e241..865e32c550aabbe61a668c969b5d8ddab4abc645 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -3834,41 +3834,57 @@ class SsaBuilder extends ResolvedVisitor {
} else if (name == 'JS_CREATE_ISOLATE') {
handleForeignCreateIsolate(node);
} else if (name == 'JS_OPERATOR_IS_PREFIX') {
- stack.add(addConstantString(backend.namer.operatorIsPrefix()));
+ // TODO(floitsch): this should be a JS_NAME.
+ stack.add(addConstantString(backend.namer.operatorIsPrefix));
} else if (name == 'JS_OBJECT_CLASS_NAME') {
+ // TODO(floitsch): this should be a JS_NAME.
String name = backend.namer.getRuntimeTypeName(compiler.objectClass);
stack.add(addConstantString(name));
} else if (name == 'JS_NULL_CLASS_NAME') {
+ // TODO(floitsch): this should be a JS_NAME.
String name = backend.namer.getRuntimeTypeName(compiler.nullClass);
stack.add(addConstantString(name));
} else if (name == 'JS_FUNCTION_CLASS_NAME') {
+ // TODO(floitsch): this should be a JS_NAME.
String name = backend.namer.getRuntimeTypeName(compiler.functionClass);
stack.add(addConstantString(name));
} else if (name == 'JS_OPERATOR_AS_PREFIX') {
- stack.add(addConstantString(backend.namer.operatorAsPrefix()));
+ // TODO(floitsch): this should be a JS_NAME.
+ stack.add(addConstantString(backend.namer.operatorAsPrefix));
} else if (name == 'JS_SIGNATURE_NAME') {
- stack.add(addConstantString(backend.namer.operatorSignature()));
+ // TODO(floitsch): this should be a JS_NAME.
+ stack.add(addConstantString(backend.namer.operatorSignature));
+ } else if (name == 'JS_TYPEDEF_TAG') {
+ // TODO(floitsch): this should be a JS_NAME.
+ stack.add(addConstantString(backend.namer.typedefTag));
} else if (name == 'JS_FUNCTION_TYPE_TAG') {
- stack.add(addConstantString(backend.namer.functionTypeTag()));
+ // TODO(floitsch): this should be a JS_NAME.
+ stack.add(addConstantString(backend.namer.functionTypeTag));
} else if (name == 'JS_FUNCTION_TYPE_VOID_RETURN_TAG') {
- stack.add(addConstantString(backend.namer.functionTypeVoidReturnTag()));
+ // TODO(floitsch): this should be a JS_NAME.
+ stack.add(addConstantString(backend.namer.functionTypeVoidReturnTag));
} else if (name == 'JS_FUNCTION_TYPE_RETURN_TYPE_TAG') {
- stack.add(addConstantString(backend.namer.functionTypeReturnTypeTag()));
+ // TODO(floitsch): this should be a JS_NAME.
+ stack.add(addConstantString(backend.namer.functionTypeReturnTypeTag));
} else if (name ==
'JS_FUNCTION_TYPE_REQUIRED_PARAMETERS_TAG') {
+ // TODO(floitsch): this should be a JS_NAME.
stack.add(addConstantString(
- backend.namer.functionTypeRequiredParametersTag()));
+ backend.namer.functionTypeRequiredParametersTag));
} else if (name ==
'JS_FUNCTION_TYPE_OPTIONAL_PARAMETERS_TAG') {
+ // TODO(floitsch): this should be a JS_NAME.
stack.add(addConstantString(
- backend.namer.functionTypeOptionalParametersTag()));
+ backend.namer.functionTypeOptionalParametersTag));
} else if (name ==
'JS_FUNCTION_TYPE_NAMED_PARAMETERS_TAG') {
+ // TODO(floitsch): this should be a JS_NAME.
stack.add(addConstantString(
- backend.namer.functionTypeNamedParametersTag()));
+ backend.namer.functionTypeNamedParametersTag));
} else if (name == 'JS_DART_OBJECT_CONSTRUCTOR') {
handleForeignDartObjectJsConstructorFunction(node);
} else if (name == 'JS_IS_INDEXABLE_FIELD_NAME') {
+ // TODO(floitsch): this should be a JS_NAME.
Element element = backend.findHelper('JavaScriptIndexingBehavior');
stack.add(addConstantString(backend.namer.operatorIs(element)));
} else if (name == 'JS_CURRENT_ISOLATE') {

Powered by Google App Engine
This is Rietveld 408576698