Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: sdk/lib/_internal/compiler/js_lib/foreign_helper.dart

Issue 767643002: dart2js: Make usage of names more consistent between compiler and runtime. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/compiler/lib/src/ssa/builder.dart ('k') | sdk/lib/_internal/compiler/js_lib/js_helper.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library _foreign_helper; 5 library _foreign_helper;
6 6
7 /** 7 /**
8 * Emits a JavaScript code fragment parameterized by arguments. 8 * Emits a JavaScript code fragment parameterized by arguments.
9 * 9 *
10 * Hash characters `#` in the [codeTemplate] are replaced in left-to-right order 10 * Hash characters `#` in the [codeTemplate] are replaced in left-to-right order
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 String JS_IS_INDEXABLE_FIELD_NAME() {} 201 String JS_IS_INDEXABLE_FIELD_NAME() {}
202 202
203 /** 203 /**
204 * Returns the object corresponding to Namer.CURRENT_ISOLATE. 204 * Returns the object corresponding to Namer.CURRENT_ISOLATE.
205 */ 205 */
206 JS_CURRENT_ISOLATE() {} 206 JS_CURRENT_ISOLATE() {}
207 207
208 /// Returns the name used for generated function types on classes and methods. 208 /// Returns the name used for generated function types on classes and methods.
209 String JS_SIGNATURE_NAME() {} 209 String JS_SIGNATURE_NAME() {}
210 210
211 /// Returns the name used to tag typedefs.
212 String JS_TYPEDEF_TAG() {}
213
211 /// Returns the name used to tag function type representations in JavaScript. 214 /// Returns the name used to tag function type representations in JavaScript.
212 String JS_FUNCTION_TYPE_TAG() {} 215 String JS_FUNCTION_TYPE_TAG() {}
213 216
214 /** 217 /**
215 * Returns the name used to tag void return in function type representations 218 * Returns the name used to tag void return in function type representations
216 * in JavaScript. 219 * in JavaScript.
217 */ 220 */
218 String JS_FUNCTION_TYPE_VOID_RETURN_TAG() {} 221 String JS_FUNCTION_TYPE_VOID_RETURN_TAG() {}
219 222
220 /** 223 /**
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 } 287 }
285 288
286 /** 289 /**
287 * JavaScript string concatenation. Inputs must be Strings. Corresponds to the 290 * JavaScript string concatenation. Inputs must be Strings. Corresponds to the
288 * HStringConcat SSA instruction and may be constant-folded. 291 * HStringConcat SSA instruction and may be constant-folded.
289 */ 292 */
290 String JS_STRING_CONCAT(String a, String b) { 293 String JS_STRING_CONCAT(String a, String b) {
291 // This body is unused, only here for type analysis. 294 // This body is unused, only here for type analysis.
292 return JS('String', '# + #', a, b); 295 return JS('String', '# + #', a, b);
293 } 296 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/ssa/builder.dart ('k') | sdk/lib/_internal/compiler/js_lib/js_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698