Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Unified Diff: pkg/compiler/lib/src/js_backend/runtime_types.dart

Issue 767643002: dart2js: Make usage of names more consistent between compiler and runtime. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/runtime_types.dart
diff --git a/pkg/compiler/lib/src/js_backend/runtime_types.dart b/pkg/compiler/lib/src/js_backend/runtime_types.dart
index cb4e509d5d91e9510b4699cb491457e946fd8441..f32d77fe9d7c8db25064145476b8b5859d5e7954 100644
--- a/pkg/compiler/lib/src/js_backend/runtime_types.dart
+++ b/pkg/compiler/lib/src/js_backend/runtime_types.dart
@@ -676,18 +676,18 @@ class TypeRepresentationGenerator extends DartTypeVisitor {
}
jsAst.LiteralString name = js.string(namer.getFunctionTypeName(type));
- addProperty(namer.functionTypeTag(), name);
+ addProperty(namer.functionTypeTag, name);
if (type.returnType.isVoid) {
- addProperty(namer.functionTypeVoidReturnTag(), js('true'));
+ addProperty(namer.functionTypeVoidReturnTag, js('true'));
} else if (!type.returnType.treatAsDynamic) {
- addProperty(namer.functionTypeReturnTypeTag(), visit(type.returnType));
+ addProperty(namer.functionTypeReturnTypeTag, visit(type.returnType));
}
if (!type.parameterTypes.isEmpty) {
- addProperty(namer.functionTypeRequiredParametersTag(),
+ addProperty(namer.functionTypeRequiredParametersTag,
visitList(type.parameterTypes));
}
if (!type.optionalParameterTypes.isEmpty) {
- addProperty(namer.functionTypeOptionalParametersTag(),
+ addProperty(namer.functionTypeOptionalParametersTag,
visitList(type.optionalParameterTypes));
}
if (!type.namedParameterTypes.isEmpty) {
@@ -699,7 +699,7 @@ class TypeRepresentationGenerator extends DartTypeVisitor {
jsAst.Expression name = js.string(names[index]);
namedArguments.add(new jsAst.Property(name, visit(types[index])));
}
- addProperty(namer.functionTypeNamedParametersTag(),
+ addProperty(namer.functionTypeNamedParametersTag,
new jsAst.ObjectInitializer(namedArguments));
}
return new jsAst.ObjectInitializer(properties);
@@ -726,7 +726,7 @@ class TypeRepresentationGenerator extends DartTypeVisitor {
type.treatAsRaw ? name : visitList(type.typeArguments, head: name);
// Add it to the function-type object.
- jsAst.LiteralString tag = js.string(namer.typedefTag());
+ jsAst.LiteralString tag = js.string(namer.typedefTag);
initializer.properties.add(new jsAst.Property(tag, encodedTypedef));
return initializer;
} else {
« no previous file with comments | « pkg/compiler/lib/src/js_backend/namer.dart ('k') | pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698