Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 744853003: Integrate the Irregexp Regular Expression Engine. (Closed)

Created:
6 years ago by zerny-google
Modified:
6 years ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Integrate the Irregexp Regular Expression Engine. BUG=http://dartbug.com/19090 R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=41949 Committed: https://code.google.com/p/dart/source/detail?r=41983

Patch Set 1 #

Patch Set 2 : method recognition #

Patch Set 3 : fix for observatory and disable global_test in checked mode #

Patch Set 4 : rebase #

Patch Set 5 : fix clang and win build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6489 lines, -4313 lines) Patch
M runtime/lib/regexp.cc View 3 chunks +36 lines, -2 lines 0 comments Download
M runtime/lib/regexp_patch.dart View 5 chunks +123 lines, -3 lines 0 comments Download
M runtime/vm/compiler.cc View 12 chunks +130 lines, -17 lines 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 4 chunks +20 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 6 chunks +37 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_range_analysis.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 4 chunks +36 lines, -0 lines 0 comments Download
M runtime/vm/growable_array.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/il_printer.cc View 2 chunks +35 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.h View 15 chunks +208 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 4 chunks +65 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 3 chunks +164 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 3 chunks +103 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 3 chunks +178 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 3 chunks +105 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 3 chunks +115 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 2 chunks +36 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 2 chunks +36 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 2 chunks +36 lines, -1 line 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 2 chunks +38 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 2 chunks +36 lines, -0 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 8 chunks +49 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 6 chunks +36 lines, -0 lines 0 comments Download
M runtime/vm/parser.h View 1 2 3 4 5 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 3 5 chunks +30 lines, -0 lines 0 comments Download
M runtime/vm/raw_object.h View 3 chunks +7 lines, -1 line 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/regexp.h View 1 2 3 4 42 chunks +388 lines, -440 lines 0 comments Download
M runtime/vm/regexp.cc View 1 2 3 4 192 chunks +1318 lines, -1587 lines 0 comments Download
M runtime/vm/regexp_assembler.h View 2 chunks +536 lines, -74 lines 0 comments Download
M runtime/vm/regexp_assembler.cc View 1 chunk +1795 lines, -4 lines 0 comments Download
M runtime/vm/regexp_ast.h View 7 chunks +187 lines, -181 lines 0 comments Download
M runtime/vm/regexp_ast.cc View 10 chunks +101 lines, -103 lines 0 comments Download
M runtime/vm/regexp_parser.h View 8 chunks +53 lines, -55 lines 0 comments Download
M runtime/vm/regexp_parser.cc View 48 chunks +280 lines, -205 lines 0 comments Download
M runtime/vm/symbols.h View 4 chunks +38 lines, -0 lines 0 comments Download
M runtime/vm/unibrow.h View 2 chunks +25 lines, -29 lines 0 comments Download
M runtime/vm/unibrow.cc View 1 2 3 4 17 chunks +47 lines, -1585 lines 0 comments Download
M runtime/vm/unibrow-inl.h View 3 chunks +6 lines, -10 lines 0 comments Download
M runtime/vm/unicode.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/vm_sources.gypi View 2 chunks +11 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 2 chunks +0 lines, -6 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
zerny-google
This CL merges the below irregexp CLs and rebases on ToT. The only additional change ...
6 years ago (2014-11-24 13:03:55 UTC) #2
Florian Schneider
rubberstamp LGTM.
6 years ago (2014-11-24 13:20:19 UTC) #3
zerny-google
Fixed an issue with unexpected empty variable descriptor used by the observatory. Also disabled regexp/global_test ...
6 years ago (2014-11-25 12:50:28 UTC) #4
zerny-google
Committed patchset #4 (id:60001) manually as 41949 (presubmit successful).
6 years ago (2014-11-25 13:10:58 UTC) #5
zerny-google
Reopened and updated this CL with fixes for the clang build (struct/class + unused warnings) ...
6 years ago (2014-11-26 09:19:12 UTC) #6
zerny-google
6 years ago (2014-11-26 09:33:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 41983 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698