| Index: runtime/vm/regexp_ast.cc
|
| diff --git a/runtime/vm/regexp_ast.cc b/runtime/vm/regexp_ast.cc
|
| index c36b890e86e358606851f81d601de255d28ee0d7..9296170dfd00efd6bd5b8c60ce0c4c188d997fee 100644
|
| --- a/runtime/vm/regexp_ast.cc
|
| +++ b/runtime/vm/regexp_ast.cc
|
| @@ -4,7 +4,8 @@
|
|
|
| #include "vm/regexp_ast.h"
|
|
|
| -// SNIP
|
| +#include "platform/utils.h"
|
| +#include "vm/os.h"
|
|
|
| namespace dart {
|
|
|
| @@ -19,7 +20,7 @@ FOR_EACH_REG_EXP_TREE_TYPE(MAKE_ACCEPT)
|
| RegExp##Name* RegExpTree::As##Name() { \
|
| return NULL; \
|
| } \
|
| - bool RegExpTree::Is##Name() { return false; }
|
| + bool RegExpTree::Is##Name() const { return false; }
|
| FOR_EACH_REG_EXP_TREE_TYPE(MAKE_TYPE_CASE)
|
| #undef MAKE_TYPE_CASE
|
|
|
| @@ -27,59 +28,59 @@ FOR_EACH_REG_EXP_TREE_TYPE(MAKE_TYPE_CASE)
|
| RegExp##Name* RegExp##Name::As##Name() { \
|
| return this; \
|
| } \
|
| - bool RegExp##Name::Is##Name() { return true; }
|
| + bool RegExp##Name::Is##Name() const { return true; }
|
| FOR_EACH_REG_EXP_TREE_TYPE(MAKE_TYPE_CASE)
|
| #undef MAKE_TYPE_CASE
|
|
|
|
|
| -static Interval ListCaptureRegisters(ZoneList<RegExpTree*>* children) {
|
| +static Interval ListCaptureRegisters(ZoneGrowableArray<RegExpTree*>* children) {
|
| Interval result = Interval::Empty();
|
| - for (int i = 0; i < children->length(); i++)
|
| - result = result.Union(children->at(i)->CaptureRegisters());
|
| + for (intptr_t i = 0; i < children->length(); i++)
|
| + result = result.Union(children->At(i)->CaptureRegisters());
|
| return result;
|
| }
|
|
|
|
|
| -Interval RegExpAlternative::CaptureRegisters() {
|
| +Interval RegExpAlternative::CaptureRegisters() const {
|
| return ListCaptureRegisters(nodes());
|
| }
|
|
|
|
|
| -Interval RegExpDisjunction::CaptureRegisters() {
|
| +Interval RegExpDisjunction::CaptureRegisters() const {
|
| return ListCaptureRegisters(alternatives());
|
| }
|
|
|
|
|
| -Interval RegExpLookahead::CaptureRegisters() {
|
| +Interval RegExpLookahead::CaptureRegisters() const {
|
| return body()->CaptureRegisters();
|
| }
|
|
|
|
|
| -Interval RegExpCapture::CaptureRegisters() {
|
| +Interval RegExpCapture::CaptureRegisters() const {
|
| Interval self(StartRegister(index()), EndRegister(index()));
|
| return self.Union(body()->CaptureRegisters());
|
| }
|
|
|
|
|
| -Interval RegExpQuantifier::CaptureRegisters() {
|
| +Interval RegExpQuantifier::CaptureRegisters() const {
|
| return body()->CaptureRegisters();
|
| }
|
|
|
|
|
| -bool RegExpAssertion::IsAnchoredAtStart() {
|
| +bool RegExpAssertion::IsAnchoredAtStart() const {
|
| return assertion_type() == RegExpAssertion::START_OF_INPUT;
|
| }
|
|
|
|
|
| -bool RegExpAssertion::IsAnchoredAtEnd() {
|
| +bool RegExpAssertion::IsAnchoredAtEnd() const {
|
| return assertion_type() == RegExpAssertion::END_OF_INPUT;
|
| }
|
|
|
|
|
| -bool RegExpAlternative::IsAnchoredAtStart() {
|
| - ZoneList<RegExpTree*>* nodes = this->nodes();
|
| - for (int i = 0; i < nodes->length(); i++) {
|
| - RegExpTree* node = nodes->at(i);
|
| +bool RegExpAlternative::IsAnchoredAtStart() const {
|
| + ZoneGrowableArray<RegExpTree*>* nodes = this->nodes();
|
| + for (intptr_t i = 0; i < nodes->length(); i++) {
|
| + RegExpTree* node = nodes->At(i);
|
| if (node->IsAnchoredAtStart()) { return true; }
|
| if (node->max_match() > 0) { return false; }
|
| }
|
| @@ -87,10 +88,10 @@ bool RegExpAlternative::IsAnchoredAtStart() {
|
| }
|
|
|
|
|
| -bool RegExpAlternative::IsAnchoredAtEnd() {
|
| - ZoneList<RegExpTree*>* nodes = this->nodes();
|
| - for (int i = nodes->length() - 1; i >= 0; i--) {
|
| - RegExpTree* node = nodes->at(i);
|
| +bool RegExpAlternative::IsAnchoredAtEnd() const {
|
| + ZoneGrowableArray<RegExpTree*>* nodes = this->nodes();
|
| + for (intptr_t i = nodes->length() - 1; i >= 0; i--) {
|
| + RegExpTree* node = nodes->At(i);
|
| if (node->IsAnchoredAtEnd()) { return true; }
|
| if (node->max_match() > 0) { return false; }
|
| }
|
| @@ -98,37 +99,37 @@ bool RegExpAlternative::IsAnchoredAtEnd() {
|
| }
|
|
|
|
|
| -bool RegExpDisjunction::IsAnchoredAtStart() {
|
| - ZoneList<RegExpTree*>* alternatives = this->alternatives();
|
| - for (int i = 0; i < alternatives->length(); i++) {
|
| - if (!alternatives->at(i)->IsAnchoredAtStart())
|
| +bool RegExpDisjunction::IsAnchoredAtStart() const {
|
| + ZoneGrowableArray<RegExpTree*>* alternatives = this->alternatives();
|
| + for (intptr_t i = 0; i < alternatives->length(); i++) {
|
| + if (!alternatives->At(i)->IsAnchoredAtStart())
|
| return false;
|
| }
|
| return true;
|
| }
|
|
|
|
|
| -bool RegExpDisjunction::IsAnchoredAtEnd() {
|
| - ZoneList<RegExpTree*>* alternatives = this->alternatives();
|
| - for (int i = 0; i < alternatives->length(); i++) {
|
| - if (!alternatives->at(i)->IsAnchoredAtEnd())
|
| +bool RegExpDisjunction::IsAnchoredAtEnd() const {
|
| + ZoneGrowableArray<RegExpTree*>* alternatives = this->alternatives();
|
| + for (intptr_t i = 0; i < alternatives->length(); i++) {
|
| + if (!alternatives->At(i)->IsAnchoredAtEnd())
|
| return false;
|
| }
|
| return true;
|
| }
|
|
|
|
|
| -bool RegExpLookahead::IsAnchoredAtStart() {
|
| +bool RegExpLookahead::IsAnchoredAtStart() const {
|
| return is_positive() && body()->IsAnchoredAtStart();
|
| }
|
|
|
|
|
| -bool RegExpCapture::IsAnchoredAtStart() {
|
| +bool RegExpCapture::IsAnchoredAtStart() const {
|
| return body()->IsAnchoredAtStart();
|
| }
|
|
|
|
|
| -bool RegExpCapture::IsAnchoredAtEnd() {
|
| +bool RegExpCapture::IsAnchoredAtEnd() const {
|
| return body()->IsAnchoredAtEnd();
|
| }
|
|
|
| @@ -138,46 +139,43 @@ bool RegExpCapture::IsAnchoredAtEnd() {
|
| // in as many cases as possible, to make it more difficult for incorrect
|
| // parses to look as correct ones which is likely if the input and
|
| // output formats are alike.
|
| -class RegExpUnparser FINAL : public RegExpVisitor {
|
| +class RegExpUnparser : public RegExpVisitor {
|
| public:
|
| - RegExpUnparser(OStream& os, Zone* zone) : os_(os), zone_(zone) {}
|
| void VisitCharacterRange(CharacterRange that);
|
| #define MAKE_CASE(Name) virtual void* Visit##Name(RegExp##Name*, \
|
| - void* data) OVERRIDE;
|
| + void* data);
|
| FOR_EACH_REG_EXP_TREE_TYPE(MAKE_CASE)
|
| #undef MAKE_CASE
|
| - private:
|
| - OStream& os_;
|
| - Zone* zone_;
|
| };
|
|
|
|
|
| void* RegExpUnparser::VisitDisjunction(RegExpDisjunction* that, void* data) {
|
| - os_ << "(|";
|
| - for (int i = 0; i < that->alternatives()->length(); i++) {
|
| - os_ << " ";
|
| - that->alternatives()->at(i)->Accept(this, data);
|
| + OS::Print("(|");
|
| + for (intptr_t i = 0; i < that->alternatives()->length(); i++) {
|
| + OS::Print(" ");
|
| + (*that->alternatives())[i]->Accept(this, data);
|
| }
|
| - os_ << ")";
|
| + OS::Print(")");
|
| return NULL;
|
| }
|
|
|
|
|
| void* RegExpUnparser::VisitAlternative(RegExpAlternative* that, void* data) {
|
| - os_ << "(:";
|
| - for (int i = 0; i < that->nodes()->length(); i++) {
|
| - os_ << " ";
|
| - that->nodes()->at(i)->Accept(this, data);
|
| + OS::Print("(:");
|
| + for (intptr_t i = 0; i < that->nodes()->length(); i++) {
|
| + OS::Print(" ");
|
| + (*that->nodes())[i]->Accept(this, data);
|
| }
|
| - os_ << ")";
|
| + OS::Print(")");
|
| return NULL;
|
| }
|
|
|
|
|
| void RegExpUnparser::VisitCharacterRange(CharacterRange that) {
|
| - os_ << AsUC16(that.from());
|
| + PrintUtf16(that.from());
|
| if (!that.IsSingleton()) {
|
| - os_ << "-" << AsUC16(that.to());
|
| + OS::Print("-");
|
| + PrintUtf16(that.to());
|
| }
|
| }
|
|
|
| @@ -185,13 +183,13 @@ void RegExpUnparser::VisitCharacterRange(CharacterRange that) {
|
|
|
| void* RegExpUnparser::VisitCharacterClass(RegExpCharacterClass* that,
|
| void* data) {
|
| - if (that->is_negated()) os_ << "^";
|
| - os_ << "[";
|
| - for (int i = 0; i < that->ranges(zone_)->length(); i++) {
|
| - if (i > 0) os_ << " ";
|
| - VisitCharacterRange(that->ranges(zone_)->at(i));
|
| + if (that->is_negated()) OS::Print("^");
|
| + OS::Print("[");
|
| + for (intptr_t i = 0; i < that->ranges()->length(); i++) {
|
| + if (i > 0) OS::Print(" ");
|
| + VisitCharacterRange((*that->ranges())[i]);
|
| }
|
| - os_ << "]";
|
| + OS::Print("]");
|
| return NULL;
|
| }
|
|
|
| @@ -199,22 +197,22 @@ void* RegExpUnparser::VisitCharacterClass(RegExpCharacterClass* that,
|
| void* RegExpUnparser::VisitAssertion(RegExpAssertion* that, void* data) {
|
| switch (that->assertion_type()) {
|
| case RegExpAssertion::START_OF_INPUT:
|
| - os_ << "@^i";
|
| + OS::Print("@^i");
|
| break;
|
| case RegExpAssertion::END_OF_INPUT:
|
| - os_ << "@$i";
|
| + OS::Print("@$i");
|
| break;
|
| case RegExpAssertion::START_OF_LINE:
|
| - os_ << "@^l";
|
| + OS::Print("@^l");
|
| break;
|
| case RegExpAssertion::END_OF_LINE:
|
| - os_ << "@$l";
|
| + OS::Print("@$l");
|
| break;
|
| case RegExpAssertion::BOUNDARY:
|
| - os_ << "@b";
|
| + OS::Print("@b");
|
| break;
|
| case RegExpAssertion::NON_BOUNDARY:
|
| - os_ << "@B";
|
| + OS::Print("@B");
|
| break;
|
| }
|
| return NULL;
|
| @@ -222,96 +220,96 @@ void* RegExpUnparser::VisitAssertion(RegExpAssertion* that, void* data) {
|
|
|
|
|
| void* RegExpUnparser::VisitAtom(RegExpAtom* that, void* data) {
|
| - os_ << "'";
|
| - Vector<const uc16> chardata = that->data();
|
| - for (int i = 0; i < chardata.length(); i++) {
|
| - os_ << AsUC16(chardata[i]);
|
| + OS::Print("'");
|
| + ZoneGrowableArray<uint16_t>* chardata = that->data();
|
| + for (intptr_t i = 0; i < chardata->length(); i++) {
|
| + PrintUtf16(chardata->At(i));
|
| }
|
| - os_ << "'";
|
| + OS::Print("'");
|
| return NULL;
|
| }
|
|
|
|
|
| void* RegExpUnparser::VisitText(RegExpText* that, void* data) {
|
| if (that->elements()->length() == 1) {
|
| - that->elements()->at(0).tree()->Accept(this, data);
|
| + (*that->elements())[0].tree()->Accept(this, data);
|
| } else {
|
| - os_ << "(!";
|
| - for (int i = 0; i < that->elements()->length(); i++) {
|
| - os_ << " ";
|
| - that->elements()->at(i).tree()->Accept(this, data);
|
| + OS::Print("(!");
|
| + for (intptr_t i = 0; i < that->elements()->length(); i++) {
|
| + OS::Print(" ");
|
| + (*that->elements())[i].tree()->Accept(this, data);
|
| }
|
| - os_ << ")";
|
| + OS::Print(")");
|
| }
|
| return NULL;
|
| }
|
|
|
|
|
| void* RegExpUnparser::VisitQuantifier(RegExpQuantifier* that, void* data) {
|
| - os_ << "(# " << that->min() << " ";
|
| + OS::Print("(# %" Pd " ", that->min());
|
| if (that->max() == RegExpTree::kInfinity) {
|
| - os_ << "- ";
|
| + OS::Print("- ");
|
| } else {
|
| - os_ << that->max() << " ";
|
| + OS::Print("%" Pd " ", that->max());
|
| }
|
| - os_ << (that->is_greedy() ? "g " : that->is_possessive() ? "p " : "n ");
|
| + OS::Print(that->is_greedy() ? "g " : that->is_possessive() ? "p " : "n ");
|
| that->body()->Accept(this, data);
|
| - os_ << ")";
|
| + OS::Print(")");
|
| return NULL;
|
| }
|
|
|
|
|
| void* RegExpUnparser::VisitCapture(RegExpCapture* that, void* data) {
|
| - os_ << "(^ ";
|
| + OS::Print("(^ ");
|
| that->body()->Accept(this, data);
|
| - os_ << ")";
|
| + OS::Print(")");
|
| return NULL;
|
| }
|
|
|
|
|
| void* RegExpUnparser::VisitLookahead(RegExpLookahead* that, void* data) {
|
| - os_ << "(-> " << (that->is_positive() ? "+ " : "- ");
|
| + OS::Print("(-> %s", (that->is_positive() ? "+ " : "- "));
|
| that->body()->Accept(this, data);
|
| - os_ << ")";
|
| + OS::Print(")");
|
| return NULL;
|
| }
|
|
|
|
|
| void* RegExpUnparser::VisitBackReference(RegExpBackReference* that,
|
| - void* data) {
|
| - os_ << "(<- " << that->index() << ")";
|
| + void*) {
|
| + OS::Print("(<- %" Pd ")", that->index());
|
| return NULL;
|
| }
|
|
|
|
|
| -void* RegExpUnparser::VisitEmpty(RegExpEmpty* that, void* data) {
|
| - os_ << '%';
|
| +void* RegExpUnparser::VisitEmpty(RegExpEmpty*, void*) {
|
| + OS::Print("%%");
|
| return NULL;
|
| }
|
|
|
|
|
| -OStream& RegExpTree::Print(OStream& os, Zone* zone) { // NOLINT
|
| - RegExpUnparser unparser(os, zone);
|
| +void RegExpTree::Print() {
|
| + RegExpUnparser unparser;
|
| Accept(&unparser, NULL);
|
| - return os;
|
| }
|
|
|
|
|
| -RegExpDisjunction::RegExpDisjunction(ZoneList<RegExpTree*>* alternatives)
|
| +RegExpDisjunction::RegExpDisjunction(
|
| + ZoneGrowableArray<RegExpTree*>* alternatives)
|
| : alternatives_(alternatives) {
|
| - DCHECK(alternatives->length() > 1);
|
| - RegExpTree* first_alternative = alternatives->at(0);
|
| + ASSERT(alternatives->length() > 1);
|
| + RegExpTree* first_alternative = alternatives->At(0);
|
| min_match_ = first_alternative->min_match();
|
| max_match_ = first_alternative->max_match();
|
| - for (int i = 1; i < alternatives->length(); i++) {
|
| - RegExpTree* alternative = alternatives->at(i);
|
| - min_match_ = Min(min_match_, alternative->min_match());
|
| - max_match_ = Max(max_match_, alternative->max_match());
|
| + for (intptr_t i = 1; i < alternatives->length(); i++) {
|
| + RegExpTree* alternative = alternatives->At(i);
|
| + min_match_ = Utils::Minimum(min_match_, alternative->min_match());
|
| + max_match_ = Utils::Maximum(max_match_, alternative->max_match());
|
| }
|
| }
|
|
|
|
|
| -static int IncreaseBy(int previous, int increase) {
|
| +static intptr_t IncreaseBy(intptr_t previous, intptr_t increase) {
|
| if (RegExpTree::kInfinity - previous < increase) {
|
| return RegExpTree::kInfinity;
|
| } else {
|
| @@ -319,16 +317,16 @@ static int IncreaseBy(int previous, int increase) {
|
| }
|
| }
|
|
|
| -RegExpAlternative::RegExpAlternative(ZoneList<RegExpTree*>* nodes)
|
| +RegExpAlternative::RegExpAlternative(ZoneGrowableArray<RegExpTree*>* nodes)
|
| : nodes_(nodes) {
|
| - DCHECK(nodes->length() > 1);
|
| + ASSERT(nodes->length() > 1);
|
| min_match_ = 0;
|
| max_match_ = 0;
|
| - for (int i = 0; i < nodes->length(); i++) {
|
| - RegExpTree* node = nodes->at(i);
|
| - int node_min_match = node->min_match();
|
| + for (intptr_t i = 0; i < nodes->length(); i++) {
|
| + RegExpTree* node = nodes->At(i);
|
| + intptr_t node_min_match = node->min_match();
|
| min_match_ = IncreaseBy(min_match_, node_min_match);
|
| - int node_max_match = node->max_match();
|
| + intptr_t node_max_match = node->max_match();
|
| max_match_ = IncreaseBy(max_match_, node_max_match);
|
| }
|
| }
|
|
|