Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 712993005: Infer range for BIT_XOR. (Closed)

Created:
6 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
6 years, 1 month ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Infer range for BIT_XOR. When selecting representations unbox integer phis that have Int32 range and have only constants or boxing operations flowing into them. BUG=http://dartbug.com/13869 R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=41667

Patch Set 1 #

Patch Set 2 : fix bugs in ParallelMoveResolver #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -15 lines) Patch
M runtime/lib/integers.cc View 1 2 3 chunks +2 lines, -9 lines 0 comments Download
M runtime/platform/utils.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 2 chunks +16 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 2 chunks +12 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 2 chunks +10 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_range_analysis.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_range_analysis.cc View 1 2 2 chunks +32 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Vyacheslav Egorov (Google)
PTAL
6 years, 1 month ago (2014-11-10 20:58:56 UTC) #2
Florian Schneider
lgtm https://codereview.chromium.org/712993005/diff/20001/runtime/vm/flow_graph_range_analysis.cc File runtime/vm/flow_graph_range_analysis.cc (right): https://codereview.chromium.org/712993005/diff/20001/runtime/vm/flow_graph_range_analysis.cc#newcode2433 runtime/vm/flow_graph_range_analysis.cc:2433: return Utils::Maximum(Utils::HighestBit(max >= 0 ? max : 0), ...
6 years, 1 month ago (2014-11-11 11:48:35 UTC) #3
Vyacheslav Egorov (Google)
thanks. comments addressed, tests added - landing. https://codereview.chromium.org/712993005/diff/20001/runtime/vm/flow_graph_range_analysis.cc File runtime/vm/flow_graph_range_analysis.cc (right): https://codereview.chromium.org/712993005/diff/20001/runtime/vm/flow_graph_range_analysis.cc#newcode2433 runtime/vm/flow_graph_range_analysis.cc:2433: return Utils::Maximum(Utils::HighestBit(max ...
6 years, 1 month ago (2014-11-11 14:29:40 UTC) #4
Vyacheslav Egorov (Google)
6 years, 1 month ago (2014-11-11 14:51:23 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 41667 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698