Infer range for BIT_XOR.

runtime/vm/flow_graph_range_analysis.cc

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_range_analysis.h"
 
 #include "vm/bit_vector.h"
 #include "vm/il_printer.h"
 
 namespace dart {
@@ skipping 2409 matching lines @@
   if (Range::ConstantMin(left_range).ConstantValue() >= 0) {
     *result_min = RangeBoundary::FromConstant(0);
     *result_max = Range::ConstantMax(left_range);
     return true;
   }
 
   return false;
 }
 
 
+static int BitSize(const Range* range) {
+  const int64_t min = Range::ConstantMin(range).ConstantValue();
+  const int64_t max = Range::ConstantMax(range).ConstantValue();
+  return Utils::Maximum(Utils::HighestBit(max >= 0 ? max : 0),

[Florian Schneider, 2014/11/11 11:48:35]

HighestBit already takes the sign into account, so I think you can simplify this
to

Utils::Maximum(HighestBit(max), HighestBit(min))

[Vyacheslav Egorov (Google), 2014/11/11 14:29:40]

Done.

+                        Utils::HighestBit(min < -1 ? ~min : 0)) + 1;
+}
+
+
+void Range::Xor(const Range* left_range,

[Florian Schneider, 2014/11/11 11:48:34]

Please add test coverage for Xor to flow_graph_range_analysis_test.cc.

[Vyacheslav Egorov (Google), 2014/11/11 14:29:40]

Done.

+                const Range* right_range,
+                RangeBoundary* result_min,
+                RangeBoundary* result_max) {
+  const int bitsize =
+      Utils::Maximum(BitSize(left_range), BitSize(right_range));
+
+  if (left_range->IsPositive() && right_range->IsPositive()) {
+    *result_min = RangeBoundary::FromConstant(0);
+  } else {
+    *result_min = RangeBoundary::FromConstant(
+        static_cast<int64_t>(-1) << bitsize);
+  }
+
+  *result_max = RangeBoundary::FromConstant(
+      (static_cast<uint64_t>(1) << bitsize) - 1);
+}
+
+
 static bool IsArrayLength(Definition* defn) {
   if (defn == NULL) {
     return false;
   }
   LoadFieldInstr* load = UnwrapConstraint(defn)->AsLoadField();
   return (load != NULL) && load->IsImmutableLengthLoad();
 }
 
 
 void Range::Add(const Range* left_range,
@@ skipping 148 matching lines @@
       break;
     }
     case Token::kSHL: {
       Range::Shl(left_range, right_range, &min, &max);
       break;
     }
     case Token::kSHR: {
       Range::Shr(left_range, right_range, &min, &max);
       break;
     }
+
     case Token::kBIT_AND:
       if (!Range::And(left_range, right_range, &min, &max)) {
         *result = Range::Full(RangeBoundary::kRangeBoundaryInt64);
         return;
       }
       break;
+
+    case Token::kBIT_XOR:
+      Range::Xor(left_range, right_range, &min, &max);
+      break;
+
     default:
       *result = Range::Full(RangeBoundary::kRangeBoundaryInt64);
       return;
   }
 
   ASSERT(!min.IsUnknown() && !max.IsUnknown());
 
   *result = Range(min, max);
 }
 
@@ skipping 480 matching lines @@
     }
   } while (CanonicalizeMaxBoundary(&max) ||
            CanonicalizeMinBoundary(&canonical_length));
 
   // Failed to prove that maximum is bounded with array length.
   return false;
 }
 
 
 }  // namespace dart