Infer range for BIT_XOR.

runtime/lib/integers.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "include/dart_api.h"
 #include "vm/dart_entry.h"
 #include "vm/dart_api_impl.h"
 #include "vm/exceptions.h"
@@ skipping 18 matching lines @@
     return !bigint.FitsIntoSmi() && !bigint.FitsIntoInt64();
   }
   if (i.IsMint()) {
     const Mint& mint = Mint::Cast(i);
     return !Smi::IsValid(mint.value());
   }
   return true;
 }
 
 
-static int BitLengthInt64(int64_t value) {
-  value ^= value >> (8 * sizeof(value) - 1);  // flip bits if negative.
-  // TODO(regis): Utils::HighestBit handles negative values. Why the above?
-  return value == 0 ? 0 : Utils::HighestBit(value) + 1;
-}
-
-
 DEFINE_NATIVE_ENTRY(Integer_bitAndFromInteger, 2) {
   const Integer& right = Integer::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, left, arguments->NativeArgAt(1));
   ASSERT(CheckInteger(right));
   ASSERT(CheckInteger(left));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_bitAndFromInteger %s & %s\n",
         right.ToCString(), left.ToCString());
   }
   const Integer& result = Integer::Handle(left.BitOp(Token::kBIT_AND, right));
@@ skipping 302 matching lines @@
   return Smi::New(result);
 }
 
 
 DEFINE_NATIVE_ENTRY(Smi_bitLength, 1) {
   const Smi& operand = Smi::CheckedHandle(arguments->NativeArgAt(0));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Smi_bitLength: %s\n", operand.ToCString());
   }
   int64_t value = operand.AsInt64Value();
-  intptr_t result = BitLengthInt64(value);
+  intptr_t result = Utils::BitLength(value);
   ASSERT(Smi::IsValid(result));
   return Smi::New(result);
 }
 
 
 // Mint natives.
 
 DEFINE_NATIVE_ENTRY(Mint_bitNegate, 1) {
   const Mint& operand = Mint::CheckedHandle(arguments->NativeArgAt(0));
   ASSERT(CheckInteger(operand));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Mint_bitNegate: %s\n", operand.ToCString());
   }
   int64_t result = ~operand.value();
   return Integer::New(result);
 }
 
 
 DEFINE_NATIVE_ENTRY(Mint_bitLength, 1) {
   const Mint& operand = Mint::CheckedHandle(arguments->NativeArgAt(0));
   ASSERT(CheckInteger(operand));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Mint_bitLength: %s\n", operand.ToCString());
   }
   int64_t value = operand.AsInt64Value();
-  intptr_t result = BitLengthInt64(value);
+  intptr_t result = Utils::BitLength(value);
   ASSERT(Smi::IsValid(result));
   return Smi::New(result);
 }
 
 
 DEFINE_NATIVE_ENTRY(Mint_shlFromInt, 2) {
   // Use the preallocated out of memory exception to avoid calling
   // into dart code or allocating any code.
   const Instance& exception =
       Instance::Handle(isolate->object_store()->out_of_memory());
@@ skipping 46 matching lines @@
   return Object::null();
 }
 
 
 DEFINE_NATIVE_ENTRY(Bigint_allocate, 1) {
   // Argument is null type arguments, since class Bigint is not parameterized.
   return Bigint::New();
 }
 
 }  // namespace dart