Issue 702343002: Fix analyzer warnings in pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 702343002: Fix analyzer warnings in pub. (Closed)

Created:
6 years, 1 month ago by nweiz

Modified:
6 years, 1 month ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix analyzer warnings in pub. R=rnystrom@google.com TBR Committed: https://code.google.com/p/dart/source/detail?r=41542

Patch Set 1 #

Total comments: 2

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	sdk/lib/_internal/pub/lib/src/validator/dependency.dart	View		2 chunks	+2 lines, -2 lines	2 comments	Download
	M	sdk/lib/_internal/pub_generated/lib/src/validator/dependency.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

Committed patchset #1 (id:1) manually as 41542 (presubmit successful).

6 years, 1 month ago (2014-11-06 02:38:18 UTC) #2

Bob Nystrom

https://codereview.chromium.org/702343002/diff/1/sdk/lib/_internal/pub/lib/src/validator/dependency.dart File sdk/lib/_internal/pub/lib/src/validator/dependency.dart (right): https://codereview.chromium.org/702343002/diff/1/sdk/lib/_internal/pub/lib/src/validator/dependency.dart#newcode157 sdk/lib/_internal/pub/lib/src/validator/dependency.dart:157: if ((dep.constraint as VersionRange).includeMin) { What if it isn't ...

6 years, 1 month ago (2014-11-06 17:14:20 UTC) #3

nweiz

6 years, 1 month ago (2014-11-06 21:11:39 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/702343002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/validator/dependency.dart (right):

https://codereview.chromium.org/702343002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/validator/dependency.dart:157: if ((dep.constraint
as VersionRange).includeMin) {
On 2014/11/06 17:14:20, Bob Nystrom wrote:
> What if it isn't a range? What if it's just a Version?

We can only get to this method if the constraint doesn't have an upper bound,
which implies that it's always a range.

Expand Messages | Collapse Messages