Fix analyzer warnings in pub.

sdk/lib/_internal/pub/lib/src/validator/dependency.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library pub.validator.dependency;
 
 import 'dart:async';
 
 import 'package:pub_semver/pub_semver.dart';
 
@@ skipping 136 matching lines @@
         '  ${dep.name}: $constraint\n';
     }
     warnings.add("$message\n"
         'Without a constraint, you\'re promising to support ${log.bold("all")} '
             'previous versions of "${dep.name}".');
   }
 
   /// Warn that dependencies should have upper bounds on their constraints.
   void _warnAboutNoConstraintUpperBound(PackageDep dep) {
     var constraint;
     if ((dep.constraint as VersionRange).includeMin) {

[Bob Nystrom, 2014/11/06 17:14:20]

What if it isn't a range? What if it's just a Version?

[nweiz, 2014/11/06 21:11:39]

We can only get to this method if the constraint doesn't have an upper bound,
which implies that it's always a range.

-      constraint = _constraintForVersion(dep.constraint.min);
+      constraint = _constraintForVersion((dep.constraint as VersionRange).min);
     } else {
       constraint = '"${dep.constraint} '
           '<${(dep.constraint as VersionRange).min.nextBreaking}"';
     }
 
     warnings.add(
         'Your dependency on "${dep.name}" should have an upper bound. For '
             'example:\n'
         '\n'
         'dependencies:\n'
         '  ${dep.name}: $constraint\n'
         '\n'
         'Without an upper bound, you\'re promising to support '
             '${log.bold("all")} future versions of ${dep.name}.');
   }
 
   /// Emits an error for any version constraints that use `^` without an
   /// appropriate SDK constraint.
-  void _errorAboutCaretConstraints(List<PackageDeps> caretDeps) {
+  void _errorAboutCaretConstraints(List<PackageDep> caretDeps) {
     var newSdkConstraint = entrypoint.root.pubspec.environment.sdkVersion
         .intersect(_postCaretPubVersions);
 
     if (newSdkConstraint.isEmpty) newSdkConstraint = _postCaretPubVersions;
 
     var buffer = new StringBuffer(
         "Older versions of pub don't support ^ version constraints.\n"
         "Make sure your SDK constraint excludes those old versions:\n"
         "\n"
         "environment:\n"
@@ skipping 18 matching lines @@
     errors.add(buffer.toString().trim());
   }
 
   /// Returns the suggested version constraint for a dependency that was tested
   /// against [version].
   String _constraintForVersion(Version version) {
     if (_caretAllowed) return "^$version";
     return '">=$version <${version.nextBreaking}"';
   }
 }