Fix analyzer warnings in pub.

sdk/lib/_internal/pub/lib/src/validator/dependency.dart

Index: sdk/lib/_internal/pub/lib/src/validator/dependency.dart
diff --git a/sdk/lib/_internal/pub/lib/src/validator/dependency.dart b/sdk/lib/_internal/pub/lib/src/validator/dependency.dart
index 51c3e36aef8741d2362304a32dc70c908ef76203..7e6a933b1ae2b00f3ae60309db1e16051dc949e8 100644
--- a/sdk/lib/_internal/pub/lib/src/validator/dependency.dart
+++ b/sdk/lib/_internal/pub/lib/src/validator/dependency.dart
@@ -155,7 +155,7 @@ class DependencyValidator extends Validator {
   void _warnAboutNoConstraintUpperBound(PackageDep dep) {
     var constraint;
     if ((dep.constraint as VersionRange).includeMin) {

[Bob Nystrom, 2014/11/06 17:14:20]

What if it isn't a range? What if it's just a Version?

[nweiz, 2014/11/06 21:11:39]

We can only get to this method if the constraint doesn't have an upper bound,
which implies that it's always a range.

-      constraint = _constraintForVersion(dep.constraint.min);
+      constraint = _constraintForVersion((dep.constraint as VersionRange).min);
     } else {
       constraint = '"${dep.constraint} '
           '<${(dep.constraint as VersionRange).min.nextBreaking}"';
@@ -174,7 +174,7 @@ class DependencyValidator extends Validator {
 
   /// Emits an error for any version constraints that use `^` without an
   /// appropriate SDK constraint.
-  void _errorAboutCaretConstraints(List<PackageDeps> caretDeps) {
+  void _errorAboutCaretConstraints(List<PackageDep> caretDeps) {
     var newSdkConstraint = entrypoint.root.pubspec.environment.sdkVersion
         .intersect(_postCaretPubVersions);