Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: sdk/lib/_internal/pub_generated/lib/src/validator/dependency.dart

Issue 702343002: Fix analyzer warnings in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub_generated/lib/src/validator/dependency.dart
diff --git a/sdk/lib/_internal/pub_generated/lib/src/validator/dependency.dart b/sdk/lib/_internal/pub_generated/lib/src/validator/dependency.dart
index 28684e96afd65810063d7e8a57f4ddd97e822efd..d558407167d1c7e1f6de1b5f9ed87db94310f147 100644
--- a/sdk/lib/_internal/pub_generated/lib/src/validator/dependency.dart
+++ b/sdk/lib/_internal/pub_generated/lib/src/validator/dependency.dart
@@ -217,7 +217,7 @@ class DependencyValidator extends Validator {
void _warnAboutNoConstraintUpperBound(PackageDep dep) {
var constraint;
if ((dep.constraint as VersionRange).includeMin) {
- constraint = _constraintForVersion(dep.constraint.min);
+ constraint = _constraintForVersion((dep.constraint as VersionRange).min);
} else {
constraint =
'"${dep.constraint} ' '<${(dep.constraint as VersionRange).min.nextBreaking}"';
@@ -232,7 +232,7 @@ class DependencyValidator extends Validator {
/// Emits an error for any version constraints that use `^` without an
/// appropriate SDK constraint.
- void _errorAboutCaretConstraints(List<PackageDeps> caretDeps) {
+ void _errorAboutCaretConstraints(List<PackageDep> caretDeps) {
var newSdkConstraint =
entrypoint.root.pubspec.environment.sdkVersion.intersect(_postCaretPubVersions);

Powered by Google App Engine
This is Rietveld 408576698