Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 694833002: Fix logging API (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix logging API. This should fix the exception I'm seeing. I'll clean up uses of the deprecated API in a separate CL. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41439

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -40 lines) Patch
M pkg/analysis_server/lib/src/analysis_logger.dart View 2 chunks +15 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/analyzer_impl.dart View 2 chunks +11 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +27 lines, -22 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 2 chunks +6 lines, -4 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
6 years, 1 month ago (2014-10-31 16:09:48 UTC) #2
scheglov
LGTM https://codereview.chromium.org/694833002/diff/1/pkg/analyzer/test/generated/utilities_test.dart File pkg/analyzer/test/generated/utilities_test.dart (right): https://codereview.chromium.org/694833002/diff/1/pkg/analyzer/test/generated/utilities_test.dart#newcode5246 pkg/analyzer/test/generated/utilities_test.dart:5246: // in tet_support.dart. As I can see, it ...
6 years, 1 month ago (2014-10-31 16:15:21 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/694833002/diff/1/pkg/analyzer/test/generated/utilities_test.dart File pkg/analyzer/test/generated/utilities_test.dart (right): https://codereview.chromium.org/694833002/diff/1/pkg/analyzer/test/generated/utilities_test.dart#newcode5246 pkg/analyzer/test/generated/utilities_test.dart:5246: // in tet_support.dart. > As I can see, it ...
6 years, 1 month ago (2014-10-31 16:21:55 UTC) #4
Brian Wilkerson
6 years, 1 month ago (2014-10-31 16:22:59 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 41439 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698