Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Side by Side Diff: pkg/analyzer/lib/src/analyzer_impl.dart

Issue 694833002: Fix logging API (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer_impl; 5 library analyzer_impl;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:io'; 8 import 'dart:io';
9 9
10 import 'generated/constant.dart'; 10 import 'generated/constant.dart';
11 import 'generated/engine.dart'; 11 import 'generated/engine.dart';
12 import 'generated/element.dart'; 12 import 'generated/element.dart';
13 import 'generated/error.dart'; 13 import 'generated/error.dart';
14 import 'generated/java_io.dart'; 14 import 'generated/java_io.dart';
15 import 'generated/sdk_io.dart'; 15 import 'generated/sdk_io.dart';
16 import 'generated/source_io.dart'; 16 import 'generated/source_io.dart';
17 import '../options.dart'; 17 import '../options.dart';
18 18
19 import 'dart:collection'; 19 import 'dart:collection';
20 20
21 import 'package:analyzer/src/generated/java_core.dart' show JavaSystem; 21 import 'package:analyzer/src/generated/java_core.dart' show JavaSystem;
22 import 'package:analyzer/src/error_formatter.dart'; 22 import 'package:analyzer/src/error_formatter.dart';
23 import 'package:analyzer/file_system/physical_file_system.dart'; 23 import 'package:analyzer/file_system/physical_file_system.dart';
24 import 'package:analyzer/source/package_map_resolver.dart'; 24 import 'package:analyzer/source/package_map_resolver.dart';
25 import 'package:analyzer/source/package_map_provider.dart'; 25 import 'package:analyzer/source/package_map_provider.dart';
26 import 'package:analyzer/source/pub_package_map_provider.dart'; 26 import 'package:analyzer/source/pub_package_map_provider.dart';
27 import 'package:analyzer/src/generated/java_engine.dart';
27 28
28 /** 29 /**
29 * The maximum number of sources for which AST structures should be kept in the cache. 30 * The maximum number of sources for which AST structures should be kept in the cache.
30 */ 31 */
31 const int _MAX_CACHE_SIZE = 512; 32 const int _MAX_CACHE_SIZE = 512;
32 33
33 DirectoryBasedDartSdk sdk; 34 DirectoryBasedDartSdk sdk;
34 35
35 /// Analyzes single library [File]. 36 /// Analyzes single library [File].
36 class AnalyzerImpl { 37 class AnalyzerImpl {
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 /** 405 /**
405 * This [Logger] prints out information comments to [stdout] and error messages 406 * This [Logger] prints out information comments to [stdout] and error messages
406 * to [stderr]. 407 * to [stderr].
407 */ 408 */
408 class StdLogger extends Logger { 409 class StdLogger extends Logger {
409 final bool log; 410 final bool log;
410 411
411 StdLogger(this.log); 412 StdLogger(this.log);
412 413
413 @override 414 @override
414 void logError(String message) { 415 void logError(String message, [CaughtException exception]) {
416 stderr.writeln(message);
417 if (exception != null) {
418 stderr.writeln(exception);
419 }
420 }
421
422 @override
423 void logError2(String message, Object exception) {
415 stderr.writeln(message); 424 stderr.writeln(message);
416 } 425 }
417 426
418 @override 427 @override
419 void logError2(String message, Exception exception) { 428 void logInformation(String message, [CaughtException exception]) {
420 stderr.writeln(message);
421 }
422
423 @override
424 void logInformation(String message) {
425 if (log) { 429 if (log) {
426 stdout.writeln(message); 430 stdout.writeln(message);
431 if (exception != null) {
432 stderr.writeln(exception);
433 }
427 } 434 }
428 } 435 }
429 436
430 @override 437 @override
431 void logInformation2(String message, Exception exception) { 438 void logInformation2(String message, Object exception) {
432 if (log) { 439 if (log) {
433 stdout.writeln(message); 440 stdout.writeln(message);
434 } 441 }
435 } 442 }
436 } 443 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698