Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: pkg/analysis_server/lib/src/analysis_logger.dart

Issue 694833002: Fix logging API (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/analysis_logger.dart
diff --git a/pkg/analysis_server/lib/src/analysis_logger.dart b/pkg/analysis_server/lib/src/analysis_logger.dart
index 8700cf37b351f5051d2836e3d21c76926de1730d..477fb37fe03ea995d776c198bbbc5dbec5eab8e1 100644
--- a/pkg/analysis_server/lib/src/analysis_logger.dart
+++ b/pkg/analysis_server/lib/src/analysis_logger.dart
@@ -6,6 +6,7 @@ library analysis.logger;
import 'package:analyzer/src/generated/engine.dart';
import 'package:logging/logging.dart' as logging;
+import 'package:analyzer/src/generated/java_engine.dart';
/**
* Instances of the class [AnalysisLogger] translate from the analysis engine's
@@ -18,22 +19,30 @@ class AnalysisLogger implements Logger {
final logging.Logger baseLogger = new logging.Logger('analysis.server');
@override
- void logError(String message) {
- baseLogger.severe(message);
+ void logError(String message, [CaughtException exception]) {
+ if (exception == null) {
+ baseLogger.severe(message);
+ } else {
+ baseLogger.severe(message, exception.exception, exception.stackTrace);
+ }
}
@override
- void logError2(String message, Exception exception) {
+ void logError2(String message, Object exception) {
baseLogger.severe(message, exception);
}
@override
- void logInformation(String message) {
- baseLogger.info(message);
+ void logInformation(String message, [CaughtException exception]) {
+ if (exception == null) {
+ baseLogger.info(message);
+ } else {
+ baseLogger.info(message, exception.exception, exception.stackTrace);
+ }
}
@override
- void logInformation2(String message, Exception exception) {
+ void logInformation2(String message, Object exception) {
baseLogger.info(message, exception);
}
}
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/analyzer_impl.dart » ('j') | pkg/analyzer/test/generated/utilities_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698