Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: pkg/analyzer/lib/src/analyzer_impl.dart

Issue 694833002: Fix logging API (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/analyzer_impl.dart
diff --git a/pkg/analyzer/lib/src/analyzer_impl.dart b/pkg/analyzer/lib/src/analyzer_impl.dart
index 4de0a6a1b5fd9a75aaf644657f8fd49e1dfc298e..40df537b7e29d2f9913865118c5d4bfec387fd18 100644
--- a/pkg/analyzer/lib/src/analyzer_impl.dart
+++ b/pkg/analyzer/lib/src/analyzer_impl.dart
@@ -24,6 +24,7 @@ import 'package:analyzer/file_system/physical_file_system.dart';
import 'package:analyzer/source/package_map_resolver.dart';
import 'package:analyzer/source/package_map_provider.dart';
import 'package:analyzer/source/pub_package_map_provider.dart';
+import 'package:analyzer/src/generated/java_engine.dart';
/**
* The maximum number of sources for which AST structures should be kept in the cache.
@@ -411,24 +412,30 @@ class StdLogger extends Logger {
StdLogger(this.log);
@override
- void logError(String message) {
+ void logError(String message, [CaughtException exception]) {
stderr.writeln(message);
+ if (exception != null) {
+ stderr.writeln(exception);
+ }
}
@override
- void logError2(String message, Exception exception) {
+ void logError2(String message, Object exception) {
stderr.writeln(message);
}
@override
- void logInformation(String message) {
+ void logInformation(String message, [CaughtException exception]) {
if (log) {
stdout.writeln(message);
+ if (exception != null) {
+ stderr.writeln(exception);
+ }
}
}
@override
- void logInformation2(String message, Exception exception) {
+ void logInformation2(String message, Object exception) {
if (log) {
stdout.writeln(message);
}

Powered by Google App Engine
This is Rietveld 408576698