Start implementing checked mode compile time errors in analyzer.

Start implementing checked mode compile time errors in analyzer.

This enables the Java-based command-line analyzer to accept the
"--enable_type_checks" flag so that it can be told whether to report
type checking errors during constant evaluation.  Also it fixes the
tests language/compile_time_constant_checked2_test and
language/compile_time_constant_checked3_test in unchecked mode, by
causing CONST_FIELD_INITIALIZER_NOT_ASSIGNABLE to be escalated to an
error only in checked mode.

Note: in order to test this properly, I had to remove a hack from
test_runner.dart which caused it to effectively ignore the "checked
mode compile-time error" test annotation when testing analyzer.  With
this hack removed, several new lines needed to be added to the .status
files.

BUG=dartbug.com/16391
R=jwren@google.com, kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40780

[Paul Berry, 2014-09-29 15:57:21]

paulberry@google.com changed reviewers:
+ jwren@google.com, kustermann@google.com

[kustermann, 2014-09-29 16:11:28]

test runner changes: lgtm

https://codereview.chromium.org/610863004/diff/1/tests/language/language_anal...
File tests/language/language_analyzer2.status (right):

https://codereview.chromium.org/610863004/diff/1/tests/language/language_anal...
tests/language/language_analyzer2.status:469: map_literal1_test/01:
CompileTimeError # Issue 16391
I don't understand why there is a difference between language_analyzer.status
and language_analyzer2.status.

Did the java-based and dart-based analyzers diverge already?

[Note: Our buildbot is AFAIK no longer running the java-based analyzer (on the
analyzer builders)].

[jwren, 2014-09-29 16:42:46]

LGTM

https://codereview.chromium.org/610863004/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerOptions.java
(right):

https://codereview.chromium.org/610863004/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerOptions.java:192:
@Option(name = "--enable_type_checks",//
feels like "constant" keyword is missing... enable_constant_type_checks?

[Paul Berry, 2014-09-29 17:42:23]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Paul Berry, 2014-09-29 17:42:23]

https://codereview.chromium.org/610863004/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerOptions.java
(right):

https://codereview.chromium.org/610863004/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerOptions.java:192:
@Option(name = "--enable_type_checks",//
On 2014/09/29 16:42:45, jwren wrote:
> feels like "constant" keyword is missing... enable_constant_type_checks?

Unfortunately, the name of this option is dictated by the test framework.

https://codereview.chromium.org/610863004/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerOptions.java:193:
usage = "Check types in constant evaluation")
During an in-person conversation, Brian brought up a concern that we don't want
to expose this option to the user until we are sure that this is really the
direction that we want to take the analyzer in.  So I've commented this out so
that the option doesn't show up in "--help".

https://codereview.chromium.org/610863004/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/610863004/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:3428:
// static type.  See dartbug.com/21119.
After some in-person discussion, I've expanded this TODO comment to clarify that
in the long run, we would prefer to implement this by having the analysis engine
output a new type of error that means "error if run in checked mode", rather
than having the analysis engine choose whether to issue the error based on
whether checked mode is enabled.

I'll try to address this issue ASAP.

https://codereview.chromium.org/610863004/diff/1/tests/language/language_anal...
File tests/language/language_analyzer2.status (right):

https://codereview.chromium.org/610863004/diff/1/tests/language/language_anal...
tests/language/language_analyzer2.status:469: map_literal1_test/01:
CompileTimeError # Issue 16391
On 2014/09/29 16:11:28, kustermann wrote:
> I don't understand why there is a difference between language_analyzer.status
> and language_analyzer2.status.
> 
> Did the java-based and dart-based analyzers diverge already?
> 
> [Note: Our buildbot is AFAIK no longer running the java-based analyzer (on the
> analyzer builders)].

Sorry--I forgot to include the correct conditions in the status file and got
myself horribly confused.  I've fixed it now and the differences are much
smaller.

The only difference between the java-based and dart-based analyzer right now is
that the fix for compile_time_constant_checked{2,3}_test/{01,05} hasn't yet been
run through the translator yet, so the dart-based analyzer still has that bug;
the analyzer doesn't.

[Paul Berry, 2014-09-29 18:59:22]

Committed patchset #2 (id:20001) manually as 40780 (presubmit successful).