Start implementing checked mode compile time errors in analyzer.

tests/language/language_analyzer2.status

 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 [ $compiler == dart2analyzer ]
 # Runtime negative test. No static errors or warnings.
 closure_call_wrong_argument_count_negative_test: skip
 
 # Test issue 12694 (was analyzer issue), (1) when "abstract" is import prefix using it as type is warning; (2) currently analyzer resolves prefix as field (don't ask)
 built_in_identifier_prefix_test: CompileTimeError # Issue 12694
@@ skipping 408 matching lines @@
 unary_plus_negative_test: CompileTimeError
 unbound_getter_test: StaticWarning
 unhandled_exception_negative_test: CompileTimeError
 unresolved_top_level_method_negative_test: StaticWarning
 vm/type_cast_vm_test: StaticWarning
 vm/type_vm_test: StaticWarning
 void_type_test: StaticWarning
 
 issue13474_test: StaticWarning, OK # Test Issue
 
-# Issue 16391. The analyzer handle compile-time error in checked only in these
-# cases:
-compile_time_constant_checked2_test/01: CompileTimeError # Language Issue 16391
-compile_time_constant_checked2_test/05: CompileTimeError # Language Issue 16391
-compile_time_constant_checked3_test/01: CompileTimeError # Language Issue 16391
-compile_time_constant_checked3_test/05: CompileTimeError # Language Issue 16391
-list_literal1_test/01: CompileTimeError # Issue 16391
-map_literal1_test/01: CompileTimeError # Issue 16391
-
 # The following lines have been left in to quickly switch back to having deferred loading
 # off by default again.
 # Deferred loading support, tests marked as failing until support is enabled by default.
 #deferred_closurize_load_library_test: Pass, Fail
 #deferred_not_loaded_check_test/*: Pass, Fail
 #deferred_shadow_load_library_test: Pass, Fail
 #deferred_constraints_constants_test/*: Pass, Fail
 #deferred_load_library_wrong_args_test/*: Pass, Fail
 #deferred_constraints_type_annotation_test/*: Pass, Fail
 #deferred_load_inval_code_test: Pass, Fail
@@ skipping 10 matching lines @@
 
 # This test uses "const Symbol('_setAt')"
 vm/reflect_core_vm_test: CompileTimeError
 
 # This test is expected to have warnings because of noSuchMethod overriding.
 regress_12561_test: StaticWarning
 
 main_not_a_function_test/01: Fail # http://dartbug.com/20030
 main_test/03: Fail # http://dartbug.com/20030
 no_main_test/01: Fail # http://dartbug.com/20030
+
+# Issue 16391. These tests are supposed to produce a compile time
+# error in checked mode, but they produce a compile time error
+# regardless of mode:
+[ $unchecked ]
+compile_time_constant_checked2_test/01: CompileTimeError # Language Issue 16391
+compile_time_constant_checked2_test/05: CompileTimeError # Language Issue 16391
+compile_time_constant_checked3_test/01: CompileTimeError # Language Issue 16391
+compile_time_constant_checked3_test/05: CompileTimeError # Language Issue 16391
+list_literal1_test/01: CompileTimeError # Issue 16391
+map_literal1_test/01: CompileTimeError # Issue 16391

[kustermann, 2014/09/29 16:11:28]

I don't understand why there is a difference between language_analyzer.status
and language_analyzer2.status.

Did the java-based and dart-based analyzers diverge already?

[Note: Our buildbot is AFAIK no longer running the java-based analyzer (on the
analyzer builders)].

[Paul Berry, 2014/09/29 17:42:23]

Sorry--I forgot to include the correct conditions in the status file and got
myself horribly confused.  I've fixed it now and the differences are much
smaller.

The only difference between the java-based and dart-based analyzer right now is
that the fix for compile_time_constant_checked{2,3}_test/{01,05} hasn't yet been
run through the translator yet, so the dart-based analyzer still has that bug;
the analyzer doesn't.